Unclear why 5 PRs were autoclosed #13213

karfau · 2021-12-21T09:13:16Z

karfau
Dec 21, 2021

Hello there,

recently (on the 17th of December) all 5 pending PRs for devDependencies in our repo have been autoclosed:
https://github.com/xmldom/xmldom/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aclosed+author%3Aapp%2Frenovate+closed%3A2021-12-17+

dependencies that were offered as an update:

@stryker-mutator/core ^5.5.0 -> ^5.5.1
prettier ^2.4.1 -> ^2.5.1
nodemon ^2.0.14 -> ^2.0.15
jest ^27.3.1 -> ^27.4.5
eslint ^8.3.0 -> ^8.4.1

We didn't change any config, so I was very surprised.

The current logs and dependency dashboard issue don't list any updates, but of course the updates that have been proposed in those 5 PRs are still present.
I was also not able to recreate the PR for stryker by remnaming the PR title.

Any help/ideas are appreciated.

Answered by rarkins

Dec 21, 2021

I think the issue is because setting :preserveSemverRanges (https://github.com/xmldom/xmldom/blob/dec787eb2b10d600dec23be9076ab9d335c121e7/renovate.json#L4) contradicts rangeStrategy=bump. I'm not sure exactly what changed in our config processing, but the problem is resolved by removing the :preserveSemverRanges preset.

View full answer

viceice · 2021-12-21T09:19:12Z

viceice
Dec 21, 2021
Maintainer

Please post the dependencies with updates log message

5 replies

karfau Dec 21, 2021
Author

I added the list of dependencies that renovate offered before closing the PRs.

What exactly do you mean by with updates log message, this one?

packageFiles with updates
{
  "config": {
    "github-actions": [
      {
        "packageFile": ".github/workflows/stryker.yml",
        "deps": [
          {
            "depName": "actions/checkout",
            "commitMessageTopic": "{{{depName}}} action",
            "datasource": "github-tags",
            "versioning": "docker",
            "depType": "action",
            "replaceString": "actions/checkout@v2",
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # renovate: tag={{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "currentValue": "v2",
            "depIndex": 0,
            "warnings": [],
            "sourceUrl": "https://github.com/actions/checkout",
            "currentVersion": "v2",
            "fixedVersion": "v2",
            "updates": []
          },
          {
            "depName": "actions/setup-node",
            "commitMessageTopic": "{{{depName}}} action",
            "datasource": "github-tags",
            "versioning": "docker",
            "depType": "action",
            "replaceString": "actions/setup-node@v2",
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # renovate: tag={{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "currentValue": "v2",
            "depIndex": 1,
            "warnings": [],
            "sourceUrl": "https://github.com/actions/setup-node",
            "currentVersion": "v2",
            "fixedVersion": "v2",
            "updates": []
          }
        ]
      },
      {
        "packageFile": ".github/workflows/test-node.js.yml",
        "deps": [
          {
            "depName": "actions/checkout",
            "commitMessageTopic": "{{{depName}}} action",
            "datasource": "github-tags",
            "versioning": "docker",
            "depType": "action",
            "replaceString": "actions/checkout@v2",
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # renovate: tag={{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "currentValue": "v2",
            "depIndex": 0,
            "warnings": [],
            "sourceUrl": "https://github.com/actions/checkout",
            "currentVersion": "v2",
            "fixedVersion": "v2",
            "updates": []
          },
          {
            "depName": "actions/setup-node",
            "commitMessageTopic": "{{{depName}}} action",
            "datasource": "github-tags",
            "versioning": "docker",
            "depType": "action",
            "replaceString": "actions/setup-node@v2",
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # renovate: tag={{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "currentValue": "v2",
            "depIndex": 1,
            "warnings": [],
            "sourceUrl": "https://github.com/actions/setup-node",
            "currentVersion": "v2",
            "fixedVersion": "v2",
            "updates": []
          },
          {
            "depName": "actions/checkout",
            "commitMessageTopic": "{{{depName}}} action",
            "datasource": "github-tags",
            "versioning": "docker",
            "depType": "action",
            "replaceString": "actions/checkout@v2",
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # renovate: tag={{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "currentValue": "v2",
            "depIndex": 2,
            "warnings": [],
            "sourceUrl": "https://github.com/actions/checkout",
            "currentVersion": "v2",
            "fixedVersion": "v2",
            "updates": []
          },
          {
            "depName": "actions/setup-node",
            "commitMessageTopic": "{{{depName}}} action",
            "datasource": "github-tags",
            "versioning": "docker",
            "depType": "action",
            "replaceString": "actions/setup-node@v2",
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # renovate: tag={{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "currentValue": "v2",
            "depIndex": 3,
            "warnings": [],
            "sourceUrl": "https://github.com/actions/setup-node",
            "currentVersion": "v2",
            "fixedVersion": "v2",
            "updates": []
          }
        ]
      }
    ],
    "npm": [
      {
        "packageFile": "package.json",
        "deps": [
          {
            "depType": "devDependencies",
            "depName": "@stryker-mutator/core",
            "currentValue": "^5.5.0",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "5.5.0",
            "depIndex": 0,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/stryker-mutator/stryker-js",
            "sourceDirectory": "packages/core",
            "homepage": "https://stryker-mutator.io/",
            "currentVersion": "5.5.0",
            "fixedVersion": "5.5.0",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "eslint",
            "currentValue": "^8.3.0",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "8.3.0",
            "depIndex": 1,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/eslint/eslint",
            "homepage": "https://eslint.org",
            "currentVersion": "8.3.0",
            "fixedVersion": "8.3.0",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "eslint-config-prettier",
            "currentValue": "^8.3.0",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "8.3.0",
            "depIndex": 2,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/prettier/eslint-config-prettier",
            "currentVersion": "8.3.0",
            "fixedVersion": "8.3.0",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "eslint-plugin-es5",
            "currentValue": "^1.5.0",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "1.5.0",
            "depIndex": 3,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/nkt/eslint-plugin-es5",
            "currentVersion": "1.5.0",
            "fixedVersion": "1.5.0",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "eslint-plugin-prettier",
            "currentValue": "^4.0.0",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "4.0.0",
            "depIndex": 4,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/prettier/eslint-plugin-prettier",
            "currentVersion": "4.0.0",
            "fixedVersion": "4.0.0",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "get-stream",
            "currentValue": "^6.0.1",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "6.0.1",
            "depIndex": 5,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/sindresorhus/get-stream",
            "currentVersion": "6.0.1",
            "fixedVersion": "6.0.1",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "jest",
            "currentValue": "^27.3.1",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "27.3.1",
            "depIndex": 6,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/facebook/jest",
            "homepage": "https://jestjs.io/",
            "currentVersion": "27.3.1",
            "fixedVersion": "27.3.1",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "nodemon",
            "currentValue": "^2.0.14",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "2.0.14",
            "depIndex": 7,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/remy/nodemon",
            "homepage": "https://nodemon.io",
            "currentVersion": "2.0.14",
            "fixedVersion": "2.0.14",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "prettier",
            "currentValue": "^2.4.1",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "2.4.1",
            "depIndex": 8,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/prettier/prettier",
            "homepage": "https://prettier.io",
            "currentVersion": "2.4.1",
            "fixedVersion": "2.4.1",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "xmltest",
            "currentValue": "^1.5.0",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "1.5.0",
            "depIndex": 9,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/karfau/xmltest",
            "currentVersion": "1.5.0",
            "fixedVersion": "1.5.0",
            "updates": []
          },
          {
            "depType": "devDependencies",
            "depName": "yauzl",
            "currentValue": "^2.10.0",
            "datasource": "npm",
            "prettyDepType": "devDependency",
            "lockedVersion": "2.10.0",
            "depIndex": 10,
            "warnings": [],
            "versioning": "npm",
            "sourceUrl": "https://github.com/thejoshwolfe/yauzl",
            "currentVersion": "2.10.0",
            "fixedVersion": "2.10.0",
            "updates": []
          },
          {
            "depType": "engines",
            "depName": "node",
            "currentValue": ">=10.0.0",
            "datasource": "github-tags",
            "lookupName": "nodejs/node",
            "versioning": "node",
            "commitMessageTopic": "Node.js",
            "prettyDepType": "engine",
            "lockedVersion": null,
            "depIndex": 11,
            "skipReason": "disabled",
            "updates": []
          }
        ],
        "packageJsonName": "@xmldom/xmldom",
        "packageFileVersion": "0.7.3",
        "packageJsonType": "library",
        "npmrc": "***********",
        "npmLock": "package-lock.json",
        "managerData": {
          "yarnZeroInstall": false
        },
        "skipInstalls": true,
        "constraints": {
          "node": ">=10.0.0",
          "npm": "<7"
        },
        "lockFiles": [
          "package-lock.json"
        ]
      }
    ]
  }
}

viceice Dec 21, 2021
Maintainer

yes, it looks like your lockfile already contains the updates and the package.json ranges are satisfying.
So renovate won't bump those ranges by default.

viceice Dec 21, 2021
Maintainer

i think this feature is the cause:

rarkins Dec 21, 2021
Maintainer

I'll take a look

karfau Dec 21, 2021
Author

Well I just checked the lock file and that's not true: https://github.com/xmldom/xmldom/blob/dec787eb2b10d600dec23be9076ab9d335c121e7/package-lock.json#L1082-L1084
it's still pointing to @stryker-mutator/core@5.5.0

But maybe it's related to the fact that those devDependencies are not pinned, since an npm install would actually install the latest available version and update the lock file.

But even if that's the case, this would still be a change in behavior.

rarkins · 2021-12-21T10:05:56Z

rarkins
Dec 21, 2021
Maintainer

I think the issue is because setting :preserveSemverRanges (https://github.com/xmldom/xmldom/blob/dec787eb2b10d600dec23be9076ab9d335c121e7/renovate.json#L4) contradicts rangeStrategy=bump. I'm not sure exactly what changed in our config processing, but the problem is resolved by removing the :preserveSemverRanges preset.

2 replies

viceice Dec 21, 2021
Maintainer

probably this:

karfau Dec 21, 2021
Author

Yes, this was it, after cleaning this up, it again works as expected.
(I was not able to mark this as the answer/being resolved.)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unclear why 5 PRs were autoclosed #13213

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 2 comments 7 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Unclear why 5 PRs were autoclosed #13213

karfau Dec 21, 2021

Replies: 2 comments · 7 replies

viceice Dec 21, 2021 Maintainer

karfau Dec 21, 2021 Author

viceice Dec 21, 2021 Maintainer

viceice Dec 21, 2021 Maintainer

rarkins Dec 21, 2021 Maintainer

karfau Dec 21, 2021 Author

rarkins Dec 21, 2021 Maintainer

viceice Dec 21, 2021 Maintainer

karfau Dec 21, 2021 Author

karfau
Dec 21, 2021

Replies: 2 comments 7 replies

viceice
Dec 21, 2021
Maintainer

karfau Dec 21, 2021
Author

viceice Dec 21, 2021
Maintainer

viceice Dec 21, 2021
Maintainer

rarkins Dec 21, 2021
Maintainer

karfau Dec 21, 2021
Author

rarkins
Dec 21, 2021
Maintainer

viceice Dec 21, 2021
Maintainer

karfau Dec 21, 2021
Author