pnpm 7 can not update lockfile

[Innei]

How are you running Renovate?

WhiteSource Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Describe the bug

When pnpm v7 come, renovate can not update lockfile, and just update package.json. so in CI mode can not do pnpm i, because lockfile is not updated.

And in every PRs, renovate bot will leave a comment.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually
The artifact failure details are included below:

File name: pnpm-lock.yaml
npm notice
npm notice New minor version of npm available! 8.5.5 -> 8.8.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.8.0
npm notice Run npm install -g npm@8.8.0 to update!
npm notice

Link there: mx-space/core#473

Relevant debug logs

Logs

 lock file error(branch="renovate/patch-nextjs-monorepo")
{
  "cmd": "pnpm",
  "err": {
    "killed": false,
    "code": 1,
    "signal": null,
    "cmd": "docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/mx-space/kami\":\"/mnt/renovate/gh/mx-space/kami\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/mx-space/kami\" docker.io/renovate/node:16.15.0 bash -l -c \"install-tool pnpm 7.0.0 && pnpm install --recursive --lockfile-only --ignore-scripts --ignore-pnpmfile\"",
    "stdout": "Installing legacy tool pnpm v7.0.0\n\nadded 1 package in 4s\n7.0.0\nProgress: resolved 1, reused 0, downloaded 0, added 0\nProgress: resolved 18, reused 0, downloaded 8, added 0\nProgress: resolved 31, reused 0, downloaded 21, added 0\nProgress: resolved 36, reused 0, downloaded 29, added 0\nProgress: resolved 40, reused 0, downloaded 36, added 0\nProgress: resolved 43, reused 0, downloaded 36, added 0\nProgress: resolved 49, reused 0, downloaded 44, added 0\nProgress: resolved 51, reused 0, downloaded 47, added 0\nProgress: resolved 57, reused 0, downloaded 51, added 0\nProgress: resolved 58, reused 0, downloaded 52, added 0\nProgress: resolved 61, reused 0, downloaded 56, added 0\nProgress: resolved 62, reused 0, downloaded 61, added 0\nProgress: resolved 64, reused 0, downloaded 64, added 0\nProgress: resolved 65, reused 0, downloaded 64, added 0\nProgress: resolved 65, reused 0, downloaded 65, added 0\nProgress: resolved 66, reused 0, downloaded 65, added 0\nProgress: resolved 66, reused 0, downloaded 66, added 0\nProgress: resolved 67, reused 0, downloaded 66, added 0\nProgress: resolved 85, reused 0, downloaded 66, added 0\nProgress: resolved 105, reused 0, downloaded 79, added 0\nProgress: resolved 137, reused 0, downloaded 106, added 0\nProgress: resolved 163, reused 0, downloaded 138, added 0\nProgress: resolved 182, reused 0, downloaded 157, added 0\nProgress: resolved 194, reused 0, downloaded 170, added 0\nProgress: resolved 207, reused 0, downloaded 180, added 0\nProgress: resolved 228, reused 0, downloaded 197, added 0\nProgress: resolved 255, reused 0, downloaded 229, added 0\nProgress: resolved 265, reused 0, downloaded 241, added 0\nProgress: resolved 277, reused 0, downloaded 254, added 0\nProgress: resolved 301, reused 0, downloaded 278, added 0\nProgress: resolved 333, reused 0, downloaded 309, added 0\nProgress: resolved 352, reused 0, downloaded 329, added 0\nProgress: resolved 370, reused 0, downloaded 347, added 0\nProgress: resolved 379, reused 0, downloaded 349, added 0\nProgress: resolved 384, reused 0, downloaded 356, added 0\nProgress: resolved 391, reused 0, downloaded 361, added 0\nProgress: resolved 398, reused 0, downloaded 367, added 0\nProgress: resolved 404, reused 0, downloaded 373, added 0\nProgress: resolved 412, reused 0, downloaded 381, added 0\nProgress: resolved 435, reused 0, downloaded 395, added 0\nProgress: resolved 449, reused 0, downloaded 408, added 0\nProgress: resolved 474, reused 0, downloaded 427, added 0\nProgress: resolved 490, reused 0, downloaded 456, added 0\nProgress: resolved 507, reused 0, downloaded 475, added 0\nProgress: resolved 526, reused 0, downloaded 493, added 0\nProgress: resolved 556, reused 0, downloaded 526, added 0\nProgress: resolved 570, reused 0, downloaded 546, added 0\nProgress: resolved 580, reused 0, downloaded 555, added 0\nProgress: resolved 591, reused 0, downloaded 560, added 0\nProgress: resolved 599, reused 0, downloaded 570, added 0\nProgress: resolved 618, reused 0, downloaded 586, added 0\nProgress: resolved 652, reused 0, downloaded 618, added 0\nProgress: resolved 670, reused 0, downloaded 644, added 0\nProgress: resolved 691, reused 0, downloaded 668, added 0\nProgress: resolved 719, reused 0, downloaded 696, added 0\nProgress: resolved 745, reused 0, downloaded 729, added 0\nProgress: resolved 747, reused 0, downloaded 732, added 0\nProgress: resolved 799, reused 0, downloaded 774, added 0\nProgress: resolved 837, reused 0, downloaded 809, added 0\nProgress: resolved 860, reused 0, downloaded 833, added 0\nProgress: resolved 872, reused 0, downloaded 856, added 0\nProgress: resolved 876, reused 0, downloaded 857, added 0\nProgress: resolved 876, reused 0, downloaded 862, added 0\nProgress: resolved 876, reused 0, downloaded 863, added 0, done\nundefined\n ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies\n\n.\n├─┬ next-pwa\n│ ├─┬ babel-loader\n│ │ ├── ✕ missing peer @babel/core@^7.0.0\n│ │ └── ✕ missing peer webpack@>=2\n│ ├─┬ clean-webpack-plugin\n│ │ └── ✕ missing peer webpack@\">=4.0.0 <6.0.0\"\n│ ├─┬ terser-webpack-plugin\n│ │ └── ✕ missing peer webpack@^5.1.0\n│ └─┬ workbox-webpack-plugin\n│   └── ✕ missing peer webpack@\"^4.4.0 || ^5.9.0\"\n├─┬ next\n│ └─┬ styled-jsx\n│   └── ✕ missing peer @babel/core@\"*\"\n├─┬ react-lazyload\n│ ├── ✕ unmet peer react@\"^0.14.0 || ^15.0.0 || ^16.0.0 || ^17.0.0\": found 18.1.0\n│ └── ✕ unmet peer react-dom@\"^0.14.0 || ^15.0.0 || ^16.0.0 || ^17.0.0\": found 18.1.0\n├─┬ mobx-react-lite\n│ └── ✕ unmet peer react@\"^16.8.0 || ^17\": found 18.1.0\n├─┬ react-markdown\n│ ├── ✕ unmet peer react@\"^15.0.0 || ^16.0.0\": found 18.1.0\n│ └─┬ html-to-react\n│   └── ✕ unmet peer react@\"^16.0 || ^17.0\": found 18.1.0\n└─┬ react-use\n  ├── ✕ unmet peer react@\"^16.8.0  || ^17.0.0\": found 18.1.0\n  └── ✕ unmet peer react-dom@\"^16.8.0  || ^17.0.0\": found 18.1.0\nPeer dependencies that should be installed:\n  @babel/core@\">=7.0.0 <8.0.0\"\n  webpack@\">=5.9.0 <6.0.0\"\n\n",
    "stderr": "npm notice \nnpm notice New minor version of npm available! 8.5.5 -> 8.8.0\nnpm notice Changelog: <https://**redacted**@8.8.0` to update!\nnpm notice \n",
    "message": "Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/mx-space/kami\":\"/mnt/renovate/gh/mx-space/kami\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/mx-space/kami\" docker.io/renovate/node:16.15.0 bash -l -c \"install-tool pnpm 7.0.0 && pnpm install --recursive --lockfile-only --ignore-scripts --ignore-pnpmfile\"\nnpm notice \nnpm notice New minor version of npm available! 8.5.5 -> 8.8.0\nnpm notice Changelog: <https://**redacted**@8.8.0` to update!\nnpm notice \n",
    "stack": "Error: Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/mnt/renovate/gh/mx-space/kami\":\"/mnt/renovate/gh/mx-space/kami\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -e NPM_CONFIG_CACHE -e npm_config_store -w \"/mnt/renovate/gh/mx-space/kami\" docker.io/renovate/node:16.15.0 bash -l -c \"install-tool pnpm 7.0.0 && pnpm install --recursive --lockfile-only --ignore-scripts --ignore-pnpmfile\"\nnpm notice \nnpm notice New minor version of npm available! 8.5.5 -> 8.8.0\nnpm notice Changelog: <https://**redacted**@8.8.0` to update!\nnpm notice \n\n    at ChildProcess.exithandler (child_process.js:383:12)\n    at ChildProcess.emit (events.js:400:28)\n    at ChildProcess.emit (domain.js:475:12)\n    at maybeClose (internal/child_process.js:1058:16)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:293:5)"
  },
  "type": "pnpm"
}

Have you created a minimal reproduction repository?

No reproduction, but I have linked to a public repo where it occurs

[rarkins]

There's a good chance this is a peer dependency failure behind the scenes. Check the stdout of the pnpm command in the debug logs

[viceice]

Breaking change of pnpm v7

• https://github.com/pnpm/pnpm/releases/tag/v7.0.0
• feat: strict-peer-dependencies is true by default pnpm/pnpm#4427

[viceice]

same issue as:

• Renovate can't update pnpm-lock.yaml when there's a peer dependencies error #15410

[viceice]

new node docker images are pushed, so now it show the real error on next (forced) run

[Jolg42]

If you want to stay on pnpm v6 and take some time to upgrade you could add this to your renovate.json

  "constraints": {
    "pnpm": "6"
  },

I just did that and from debug logs it resolves correctly to latest v6 after, which fixes the problem until we upgrade to v7 and remove this.

DEBUG: Resolved version(branch="renovate/dependencies-(non-major)")
{
  "toolName": "pnpm",
  "constraint": "6",
  "resolvedVersion": "6.32.11"
}

See https://docs.renovatebot.com/configuration-options/#constraints

[chris-house]

I tried this and have debug logs turned on, and for some reason it didnt show this "resolvedVersion": "6.32.11"