Duplicate pipelines with minimumReleaseAge and slow enough GitLab instance #23132
-
How are you running Renovate?Self-hosted Renovate If you're self-hosting Renovate, tell us what version of Renovate you run.35.158.0 If you're self-hosting Renovate, select which platform you are using.GitLab self-hosted Was this something which used to work for you, and then stopped?It used to work, and then stopped Describe the problemRenovate's external commit status, What this means in practice is that people (not using Renovate's automerge) can accidentally end up merging broken changes as only one of the pipelines is considered in the Merge Request's status by GitLab itself (and used to block/allow merging). What leads me to believe this is due to GitLab's performance, is because the status/external job ends up on the correct pipeline (i.e. no duplicates) sometimes, without any obvious differences between the Merge Requests. And furthermore, this only started happening after we migrated our GitLab environment and started experiencing some performance issues on its end. The same issue was last discussed here: #8759 Some timestamps I've observed (**not** from the same time as the included debug logs)2023-07-04T11:38:31.000+03:00 -> commit created by Renovate
2023-07-04T11:38:32.143+03:00 -> git push
2023-07-04T11:38:32.564+03:00 -> "Got res with 0 results", while Renovate fetches existing statuses for commit
2023-07-04T11:38:32.564+03:00 -> "Updating renovate/stability-days status check state to green" (but can't rely on log timestamps completely)
2023-07-04T11:38:33.482+03:00 -> "real" pipeline created
2023-07-04T11:38:33.488+03:00 -> first job created in "real" pipeline
2023-07-04T11:38:33.652+03:00 -> Renovate's separate pipeline created -> the pipeline (and therefore the first status for the commit) was created ~1s after Renovate tried to fetch the status. I'm not sure if there is any better solution for this than just increasing the sleep (or making it configurable is probably the better option) 🤔 Minimal repro: have tried to reproduce this on GitLab.com but to no success, and reproducing a slow self-hosted GitLab instance is kinda impossible just for this. Relevant debug logsLogs
Have you created a minimal reproduction repository?I have explained in the description why a minimal reproduction is impossible |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
Maybe we can add a new |
Beta Was this translation helpful? Give feedback.
Maybe we can add a new
RENOVATE_X_
parameter to let people control the sleep duration