-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vendored gems when updating with bundler #11004
Comments
Thank you for providing a reproduction! 🎉 🚀 The Renovate team will take a look at the reproduction repository. |
We will want to do this automatically without needing it to be opted into. i.e. if vendored files are detected then we commit any updates to them. The question is: how to detect if they're pre-existing? e.g. presence of Should be similar to how we do it in Composer/PHP |
We would also like this functionality and cache to the standard |
@rarkins I agree that simply checking for the existance of any |
Just checking to see if anyone is actively looking / prioritizing this issue. |
I'm not aware of anyone working on it, but considering we have a few other managers doing similar/same things, it should not be particularly complex for a community contribution. |
FYI, I was able to solve this using In the repository config, I have {
"packageRules": [
{
"matchManagers": ["bundler"],
"postUpgradeTasks": {
"commands": ["bundle package --all --all-platforms"],
"fileFilters": ["vendor/cache/**/*"],
"executionMode": "branch"
}
}]
} In order to allow executing the {
"allowedPostUpgradeCommands": ["^bundle package"]
} Now, we have updated |
What would you like Renovate to be able to do?
When submitting a PR to update a bundler dependency, it would be nice if Renovate updated the vendored gems in
cache_path
in addition to just tweaking the version numbers in Gemfile & Gemfile.lockI set up https://github.com/jdelStrother/renovate-gem-caching as a test case, which caches its gems here - https://github.com/jdelStrother/renovate-gem-caching/tree/main/vendor/cache
Here's Renovate's PR, which bumps the Gemfile version, but doesn't touch vendor/cache.
And for comparison here's Dependabot's PR, which bumps the Gemfile version, and includes the updated gems. (You can opt in to this with
vendor:true
in dependabot's settings)Tell us what requirements you need solving, and be sure to mention too if this is part of any "bigger" problem you're trying to solve
I'm running tests with github actions and an installation step like:
which fails with
Some gems seem to be missing from your vendor/cache directory
duringbundle install
if the cache directory isn't kept up-to-date with new gem versions.The text was updated successfully, but these errors were encountered: