Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): migrate renamed monorepos #11319

Merged
merged 2 commits into from Aug 18, 2021
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Aug 18, 2021

Changes:

Adds migrations for renamed monorepo presets.

Context:

Closes #11318

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator Author

rarkins commented Aug 18, 2021

@HonkingGoose can you double check that I caught every change?

Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still checking the others, but we can fix this one now.

lib/config/presets/common.ts Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm we have migrated the changes that I made in my original PR: https://github.com/renovatebot/renovate/pull/10243/files

I don't think we edited it any further in the feat: v26 PR: https://github.com/renovatebot/renovate/pull/10995/files#diff-79c717b40c9bee60d2c9256ae4944499e287678a4880b0c457ecdd1b8e111466

But might be good to run a diff between these two somehow to confirm we didn't make any further changes????

@rarkins
Copy link
Collaborator Author

rarkins commented Aug 18, 2021

I'd prefer to merge this ASAP if it satisfies both our checks

@HonkingGoose
Copy link
Collaborator

I ran a diff between my original PR and the feat: v26 PR, and we didn't make any more edits to existing monorepos.

We did add new monorepos in the feat: v26 PR, but new monorepos don't need a migration, as they're new. 😄

I'd say we're good to merge now.

@HonkingGoose HonkingGoose self-requested a review August 18, 2021 09:43
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully you've found all. 😅

@rarkins rarkins merged commit 70b5396 into main Aug 18, 2021
@rarkins rarkins deleted the fix/renamed-presets-migration branch August 18, 2021 10:23
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 26.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate breaking preset names in v26
4 participants