Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): migrate renamed monorepos #11319

Merged
merged 2 commits into from
Aug 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 37 additions & 1 deletion lib/config/presets/common.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export const removedPresets = {
export const removedPresets: Record<string, string | null> = {
':automergeBranchMergeCommit': ':automergeBranch',
':automergeBranchPush': ':automergeBranch',
':base': 'config:base',
Expand All @@ -23,3 +23,39 @@ export const removedPresets = {
'helpers:oddIsUnstable': null,
'helpers:oddIsUnstablePackages': null,
};

const renamedMonorepos: Record<string, string> = {
'arcus event-grid': 'arcus.event-grid',
'arcus security': 'arcus.security',
'arcus messaging': 'arcus.messaging',
'arcus observability': 'arcus.observability',
'arcus webapi': 'arcus.webapi',
'arcus background-jobs': 'arcus.background-jobs',
'aspnet AspNetWebStack': 'aspnet aspnetwebstack',
'aspnet Extensions': 'aspnet extensions',
'System.IO.Abstractions': 'system.io.abstractions',
angular1: 'angularjs',
angularcli: 'angular-cli',
Fontsource: 'fontsource',
hamcrest: 'javahamcrest',
HotChocolate: 'hotchocolate',
infrastructure: 'infrastructure-ui',
lingui: 'linguijs',
MassTransit: 'masstransit',
material: 'material-components-web',
mui: 'material-ui',
openfeign: 'feign',
opentelemetry: 'opentelemetry-js',
OpenTelemetryDotnet: 'opentelemetry-dotnet',
picasso: 'picassojs',
reactrouter: 'react-router',
sentry: 'sentry-javascript',
Steeltoe: 'steeltoe',
stryker: 'stryker-js',
Swashbuckle: 'swashbuckle-aspnetcore',
};

for (const [from, to] of Object.entries(renamedMonorepos)) {
removedPresets[`monorepo:${from}`] = `monorepo:${to}`;
removedPresets[`group:${from}Monorepo`] = `group:${to}Monorepo`;
}
31 changes: 31 additions & 0 deletions lib/config/presets/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,37 @@ describe('config/presets/index', () => {
const res = await presets.getPreset('helpers:oddIsUnstable', {});
expect(res).toEqual({});
});
it('handles renamed monorepos', async () => {
const res = await presets.getPreset('monorepo:opentelemetry', {});
expect(res).toMatchInlineSnapshot(`
Object {
"description": Array [
"opentelemetry-js monorepo",
],
"matchSourceUrlPrefixes": Array [
"https://github.com/open-telemetry/opentelemetry-js",
],
}
`);
});
it('handles renamed monorepo groups', async () => {
const res = await presets.getPreset('group:opentelemetryMonorepo', {});
expect(res).toMatchInlineSnapshot(`
Object {
"packageRules": Array [
Object {
"description": Array [
"Group packages from opentelemetry-js monorepo together",
],
"extends": Array [
"monorepo:opentelemetry-js",
],
"groupName": "opentelemetry-js monorepo",
},
],
}
`);
});
it('gets linters', async () => {
const res = await presets.getPreset('packages:linters', {});
expect(res).toMatchSnapshot();
Expand Down