New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce enum programming-language #12052
refactor: introduce enum programming-language #12052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should deprecate language
from managers, as we now have manager with multiple languages.
I think that can confuse users because they expect language config to apply to them partially.
Golang = 'golang', | ||
Java = 'java', | ||
JavaScript = 'js', | ||
NET = 'dotnet', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 correct spelling would be .NET
, should we use DotNet
instead?
@rarkins @JamieMagee WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but the brand guidelines are have it as Dotnet
.
Java = 'java', | ||
JavaScript = 'js', | ||
NET = 'dotnet', | ||
NodeJS = 'node', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically no programming language.
I think we should deprecate language
from managers.
@rarkins @JamieMagee WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is not programming language, but ProgrammingLanguage
variable name is more descriptive than Language
. I open for good suggestions
Let's discuss in an issue. Maybe I already had one, because I am also uncomfortable with how it works today. The biggest challenge is how to keep backwards compatible behavior for those using it. Another possibility is adding config warnings for a while saying "stop using languages please" and hope the app users all change? :) But for now should we do this refactoring? |
#4165
Yes, let's do it, as it's mostly done and don't harm. |
🎉 This PR is included in version 28.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Added enum ProgrammingLanguage instead of list of constant variables
Context:
This change was requested to be done in separate PR #11690
Documentation
How I've tested my work
I have verified these changes via: