Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce enum programming-language #12052

Merged
merged 5 commits into from Oct 13, 2021
Merged

refactor: introduce enum programming-language #12052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b3dab8
refactor: introduce enum programming-language
pret-a-porter Sep 11, 2021
d9788a4
Merge branch 'main' into refactor/programming_language
pret-a-porter Oct 9, 2021
1ca7871
Merge branch 'main' into refactor/programming_language
rarkins Oct 11, 2021
14c1cc6
Merge branch 'main' into refactor/programming_language
rarkins Oct 13, 2021
c0353ba
Merge branch 'main' into refactor/programming_language
pret-a-porter Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/constants/index.ts
View file
Open in desktop
@@ -1 +1,2 @@
export * from './platforms';
export * from './programming-language';
12 changes: 0 additions & 12 deletions lib/constants/languages.ts
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions lib/constants/programming-language.ts
View file
Open in desktop
@@ -0,0 +1,14 @@
export enum ProgrammingLanguage {
viceice marked this conversation as resolved.
Show resolved Hide resolved
Dart = 'dart',
Docker = 'docker',
Elixir = 'elixir',
Golang = 'golang',
Java = 'java',
JavaScript = 'js',
NET = 'dotnet',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 correct spelling would be .NET, should we use DotNet instead?

@rarkins @JamieMagee WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but the brand guidelines are have it as Dotnet.

NodeJS = 'node',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically no programming language.

I think we should deprecate language from managers.

@rarkins @JamieMagee WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is not programming language, but ProgrammingLanguage variable name is more descriptive than Language. I open for good suggestions

PHP = 'php',
Python = 'python',
Ruby = 'ruby',
Rust = 'rust',
}
4 changes: 2 additions & 2 deletions lib/manager/ansible/index.ts
View file
Open in desktop
@@ -1,7 +1,7 @@
import { LANGUAGE_DOCKER } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import extractPackageFile from './extract';

const language = LANGUAGE_DOCKER;
const language = ProgrammingLanguage.Docker;

export { extractPackageFile, language };

Expand Down
4 changes: 2 additions & 2 deletions lib/manager/bundler/index.ts
View file
Open in desktop
@@ -1,10 +1,10 @@
import { LANGUAGE_RUBY } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as rubyVersioning from '../../versioning/ruby';
import { updateArtifacts } from './artifacts';
import { extractPackageFile } from './extract';
import { getRangeStrategy } from './range';

const language = LANGUAGE_RUBY;
const language = ProgrammingLanguage.Ruby;
export const supportsLockFileMaintenance = true;

/*
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/cake/index.ts
View file
Open in desktop
@@ -1,10 +1,10 @@
import moo from 'moo';
import { LANGUAGE_DOT_NET } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import { id as datasource } from '../../datasource/nuget';
import { SkipReason } from '../../types';
import { PackageDependency, PackageFile } from '../types';

export const language = LANGUAGE_DOT_NET;
export const language = ProgrammingLanguage.NET;

export const defaultConfig = {
fileMatch: ['\\.cake$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/cargo/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_RUST } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as cargoVersioning from '../../versioning/cargo';
import { updateArtifacts } from './artifacts';
import { extractPackageFile } from './extract';

const language = LANGUAGE_RUST;
const language = ProgrammingLanguage.Rust;
export const supportsLockFileMaintenance = true;

export { extractPackageFile, updateArtifacts, language };
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/composer/index.ts
View file
Open in desktop
@@ -1,10 +1,10 @@
import { LANGUAGE_PHP } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import { updateArtifacts } from './artifacts';
import { extractPackageFile } from './extract';
import { getRangeStrategy } from './range';
import { composerVersioningId } from './utils';

const language = LANGUAGE_PHP;
const language = ProgrammingLanguage.PHP;
export const supportsLockFileMaintenance = true;

export { extractPackageFile, updateArtifacts, language, getRangeStrategy };
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/docker-compose/index.ts
View file
Open in desktop
@@ -1,7 +1,7 @@
import { LANGUAGE_DOCKER } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import { extractPackageFile } from './extract';

const language = LANGUAGE_DOCKER;
const language = ProgrammingLanguage.Docker;

export { extractPackageFile, language };

Expand Down
4 changes: 2 additions & 2 deletions lib/manager/dockerfile/index.ts
View file
Open in desktop
@@ -1,7 +1,7 @@
import { LANGUAGE_DOCKER } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import { extractPackageFile } from './extract';

const language = LANGUAGE_DOCKER;
const language = ProgrammingLanguage.Docker;

export { extractPackageFile, language };

Expand Down
4 changes: 2 additions & 2 deletions lib/manager/droneci/index.ts
View file
Open in desktop
@@ -1,7 +1,7 @@
import { LANGUAGE_DOCKER } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import { extractPackageFile } from './extract';

const language = LANGUAGE_DOCKER;
const language = ProgrammingLanguage.Docker;

export { extractPackageFile, language };

Expand Down
4 changes: 2 additions & 2 deletions lib/manager/gitlabci/index.ts
View file
Open in desktop
@@ -1,7 +1,7 @@
import { LANGUAGE_DOCKER } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import { extractAllPackageFiles, extractPackageFile } from './extract';

const language = LANGUAGE_DOCKER;
const language = ProgrammingLanguage.Docker;

export { extractAllPackageFiles, extractPackageFile, language };

Expand Down
4 changes: 2 additions & 2 deletions lib/manager/gomod/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_GOLANG } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import { updateArtifacts } from './artifacts';
import { extractPackageFile } from './extract';
import { updateDependency } from './update';

export const language = LANGUAGE_GOLANG;
export const language = ProgrammingLanguage.Golang;
export { extractPackageFile, updateDependency, updateArtifacts };

export const defaultConfig = {
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/gradle/index.ts
View file
Open in desktop
@@ -1,4 +1,4 @@
import { LANGUAGE_JAVA } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as gradleVersioning from '../../versioning/gradle';
import type {
ExtractConfig,
Expand Down Expand Up @@ -26,7 +26,7 @@ export function updateDependency(
: shallow.updateDependency(params);
}

export const language = LANGUAGE_JAVA;
export const language = ProgrammingLanguage.Java;

export const defaultConfig = {
fileMatch: [
Expand Down
28 changes: 2 additions & 26 deletions lib/manager/index.ts
View file
Open in desktop
@@ -1,16 +1,4 @@
import {
LANGUAGE_DART,
LANGUAGE_DOCKER,
LANGUAGE_DOT_NET,
LANGUAGE_ELIXIR,
LANGUAGE_GOLANG,
LANGUAGE_JAVASCRIPT,
LANGUAGE_NODE,
LANGUAGE_PHP,
LANGUAGE_PYTHON,
LANGUAGE_RUBY,
LANGUAGE_RUST,
} from '../constants/languages';
import { ProgrammingLanguage } from '../constants';
import type { RangeStrategy } from '../types';
import managers from './api';
import type {
Expand All @@ -24,19 +12,7 @@ import type {

const managerList = Array.from(managers.keys());

const languageList = [
LANGUAGE_DART,
LANGUAGE_DOCKER,
LANGUAGE_DOT_NET,
LANGUAGE_ELIXIR,
LANGUAGE_GOLANG,
LANGUAGE_JAVASCRIPT,
LANGUAGE_NODE,
LANGUAGE_PHP,
LANGUAGE_PYTHON,
LANGUAGE_RUBY,
LANGUAGE_RUST,
];
const languageList = Object.values(ProgrammingLanguage);
viceice marked this conversation as resolved.
Show resolved Hide resolved

export function get<T extends keyof ManagerApi>(
manager: string,
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/kubernetes/index.ts
View file
Open in desktop
@@ -1,8 +1,8 @@
import { LANGUAGE_DOCKER } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';

export { extractPackageFile } from './extract';

export const language = LANGUAGE_DOCKER;
export const language = ProgrammingLanguage.Docker;

export const defaultConfig = {
fileMatch: [],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/maven/index.ts
View file
Open in desktop
@@ -1,10 +1,10 @@
import { LANGUAGE_JAVA } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as mavenVersioning from '../../versioning/maven';

export { extractAllPackageFiles } from './extract';
export { updateDependency } from './update';

export const language = LANGUAGE_JAVA;
export const language = ProgrammingLanguage.Java;

export const defaultConfig = {
fileMatch: ['\\.pom\\.xml$', '(^|/)pom\\.xml$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/meteor/index.ts
View file
Open in desktop
@@ -1,8 +1,8 @@
import { LANGUAGE_JAVASCRIPT } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';

export { extractPackageFile } from './extract';

export const language = LANGUAGE_JAVASCRIPT;
export const language = ProgrammingLanguage.JavaScript;

export const defaultConfig = {
fileMatch: ['(^|/)package.js$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/mix/index.ts
View file
Open in desktop
@@ -1,10 +1,10 @@
import { LANGUAGE_ELIXIR } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as hexVersioning from '../../versioning/hex';

export { extractPackageFile } from './extract';
export { updateArtifacts } from './artifacts';

export const language = LANGUAGE_ELIXIR;
export const language = ProgrammingLanguage.Elixir;

export const defaultConfig = {
fileMatch: ['(^|/)mix\\.exs$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/nodenv/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_NODE } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as nodeVersioning from '../../versioning/node';

export { extractPackageFile } from './extract';

export const language = LANGUAGE_NODE;
export const language = ProgrammingLanguage.NodeJS;

export const defaultConfig = {
fileMatch: ['(^|/).node-version$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/npm/index.ts
View file
Open in desktop
@@ -1,4 +1,4 @@
import { LANGUAGE_JAVASCRIPT } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as npmVersioning from '../../versioning/npm';

export { detectGlobalConfig } from './detect';
Expand All @@ -10,7 +10,7 @@ export {
} from './update';
export { getRangeStrategy } from './range';

export const language = LANGUAGE_JAVASCRIPT;
export const language = ProgrammingLanguage.JavaScript;
export const supportsLockFileMaintenance = true;

export const defaultConfig = {
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/nuget/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_DOT_NET } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';

export { extractPackageFile } from './extract';
export { updateArtifacts } from './artifacts';

export const language = LANGUAGE_DOT_NET;
export const language = ProgrammingLanguage.NET;

export const defaultConfig = {
fileMatch: [
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/nvm/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_NODE } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as nodeVersioning from '../../versioning/node';

export { extractPackageFile } from './extract';

export const language = LANGUAGE_NODE;
export const language = ProgrammingLanguage.NodeJS;

export const defaultConfig = {
fileMatch: ['(^|/)\\.nvmrc$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/pip-compile/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_PYTHON } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';

export { extractPackageFile } from '../pip_requirements/extract';
export { updateArtifacts } from './artifacts';

export const language = LANGUAGE_PYTHON;
export const language = ProgrammingLanguage.Python;
export const supportsLockFileMaintenance = true;

export const defaultConfig = {
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/pip_requirements/index.ts
View file
Open in desktop
@@ -1,10 +1,10 @@
import { LANGUAGE_PYTHON } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';

export { updateArtifacts } from './artifacts';
export { extractPackageFile } from './extract';
export { getRangeStrategy } from './range';

export const language = LANGUAGE_PYTHON;
export const language = ProgrammingLanguage.Python;

export const defaultConfig = {
fileMatch: ['(^|/)([\\w-]*)requirements\\.(txt|pip)$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/pip_setup/index.ts
View file
Open in desktop
@@ -1,8 +1,8 @@
import { LANGUAGE_PYTHON } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';

export { extractPackageFile } from './extract';

export const language = LANGUAGE_PYTHON;
export const language = ProgrammingLanguage.Python;

export const defaultConfig = {
fileMatch: ['(^|/)setup.py$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/pipenv/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_PYTHON } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';

export { extractPackageFile } from './extract';
export { updateArtifacts } from './artifacts';

export const language = LANGUAGE_PYTHON;
export const language = ProgrammingLanguage.Python;
export const supportsLockFileMaintenance = true;

export const defaultConfig = {
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/poetry/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_PYTHON } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';

export { extractPackageFile } from './extract';
export { updateArtifacts } from './artifacts';

export const language = LANGUAGE_PYTHON;
export const language = ProgrammingLanguage.Python;
export const supportsLockFileMaintenance = true;

export const defaultConfig = {
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/pyenv/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_PYTHON } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as dockerVersioning from '../../versioning/docker';

export { extractPackageFile } from './extract';

export const language = LANGUAGE_PYTHON;
export const language = ProgrammingLanguage.Python;

export const defaultConfig = {
fileMatch: ['(^|/).python-version$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/ruby-version/index.ts
View file
Open in desktop
@@ -1,9 +1,9 @@
import { LANGUAGE_RUBY } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import * as rubyVersioning from '../../versioning/ruby';

export { extractPackageFile } from './extract';

export const language = LANGUAGE_RUBY;
export const language = ProgrammingLanguage.Ruby;

export const defaultConfig = {
fileMatch: ['(^|/)\\.ruby-version$'],
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/setup-cfg/index.ts
View file
Open in desktop
@@ -1,10 +1,10 @@
import { LANGUAGE_PYTHON } from '../../constants/languages';
import { ProgrammingLanguage } from '../../constants';
import { id as versioning } from '../../versioning/pep440';

export { extractPackageFile } from './extract';
export { getRangeStrategy } from './range';

export const language = LANGUAGE_PYTHON;
export const language = ProgrammingLanguage.Python;

export const defaultConfig = {
fileMatch: ['(^|/)setup\\.cfg$'],
Expand Down