New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab CI trigger includes #12178
Comments
Can you please extend the description with a concrete sample, i don't see anything there wich should be updated by renovate. |
@viceice I updated the description with a concrete example for the "local files" scenario. As you can see renovate added the digest to the I assumed that the "gitlabci-include" is only looking for If you would need a complete "how to reproduce" repository please let me know. I'll try to provide this in the next days. |
Hi there, Help us by making a minimal reproduction repository. Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. To get started, please read our guide on creating a minimal reproduction to understand what is needed. We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment. Good luck, The Renovate team |
Reproduction repository: https://gitlab.com/1O/renovate-12178-reproduction/-/tree/master See that renovate created 2 branches in this repo:
These branches just change the file https://gitlab.com/1O/renovate-12178-reproduction/-/blob/renovate/digests-pin/.gitlab-ci.yml. However the file hosting the triggered Pipeline https://gitlab.com/1O/renovate-12178-reproduction/-/blob/master/.gitlab-ci-child.yml is not touched at all. However my understanding would be that the exact same Branches should be created for I hope this made my point clear. If not please let me know. |
@Bruceforce I think the problem you have is with the file match and renovate is simply not looking at that file, I have several projects where other triggered pipeline files are managed by renovate. See the docs here for details on the default match, which is expecting files follow what is typically the GitLab naming standard of |
@aarongoldenthal Thanks for the hint. However I think that would only be a workaround for the problem. If renaming or adjusting the is filematch of the gitlabci-manager would be the "official solution", then you also would not need the gitlabci-include manager. This particular feature request is to support a check for triggered pipelines like the gitlabci-include manager does for includes. The naming of the file should not matter in this case. It could also be that you trigger a Pipeline which is not in the same repository (same as with includes). That's why I think this feature request is still valid. I'm sorry if I missed something or got you wrong. |
I think it's a good time to merge both gitlab managers, as they do some same things |
This comment has been minimized.
This comment has been minimized.
@aarongoldenthal no worries, but this is still not what I meant in particular. However this is a very interesting use case / feature request by itself in my opinion! What I meant is (for your given example):
I've also given an example in #12178 (comment). Of course this might not always be intended, for example If you explicitly not want to update images in the triggered pipeline because you do not own it, so this behavior should be configurable. |
I think that being able to "crawl" for files which aren't otherwise found is a good idea, because you can't always find everything with There are already abilities to ignore files if people need, such as |
What would you like Renovate to be able to do?
It would be great if renovate would support Gitlab CI triggered Pipeline includes. See https://docs.gitlab.com/ee/ci/yaml/#trigger-syntax-for-child-pipeline
For local files this would look like:
.gitlab-ci.yml
.gitlab-ci-backend.yml
Note: There is also the possibility to include "remote files". This would look like:
If you have any ideas on how this should be implemented, please tell us here.
Currently renovate is only looking for a structure like
defined in https://github.com/renovatebot/renovate/blob/main/lib/manager/gitlabci-include/extract.ts to allow "general" includes. The triggered includes should be quite similar to set up if I got it right.
Is this a feature you are interested in implementing yourself?
No
The text was updated successfully, but these errors were encountered: