fix(go): Mimic Go logic for GOPRIVATE parsing
#13166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the parsing of `GOPRIVATE`/`GONOPROXY` matches the behaviour of Go itself. The documentation for these values state it matches the logic of `path.Match`, however in reality it's actually a prefix based match. Updating the regex to allow for either an exact match, or a match where the configured value is a prefix of the package, when a `/` is added. Additionally, strip any trailing `/`'s from the configured value, as this matches the logic that Go takes when matching. Fixes renovatebot#13138
zharinov
approved these changes
Dec 17, 2021
rarkins
changed the title
GOPRIVATE parsingGOPRIVATE parsing
|
🎉 This PR is included in version 31.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
zanitete
pushed a commit
to nagra-insight/renovate
that referenced
this pull request
Jan 4, 2022
Ensure that the parsing of `GOPRIVATE`/`GONOPROXY` matches the behaviour of Go itself. The documentation for these values state it matches the logic of `path.Match`, however in reality it's actually a prefix based match. Updating the regex to allow for either an exact match, or a match where the configured value is a prefix of the package, when a `/` is added. Additionally, strip any trailing `/`'s from the configured value, as this matches the logic that Go takes when matching. Fixes renovatebot#13138
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Ensure that the parsing of
GOPRIVATE/GONOPROXYmatches the behaviour of Go itself.The documentation for these values state it matches the logic of
path.Match, however in reality it's actually a prefix based match.Updating the regex to allow for either an exact match, or a match where the configured value is a prefix of the package, when a
/is added.Additionally, strip any trailing
/'s from the configured value, as this matches the logic that Go takes when matching.Context:
Closes #13138
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: