Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): Mimic Go logic for GOPRIVATE parsing #13166

Merged
merged 1 commit into from
Dec 17, 2021
Merged

fix(go): Mimic Go logic for GOPRIVATE parsing #13166

merged 1 commit into from
Dec 17, 2021

Commits on Dec 17, 2021

  1. fix: Mimic Go logic for GOPRIVATE parsing 

    Ensure that the parsing of `GOPRIVATE`/`GONOPROXY` matches the behaviour of Go itself.

The documentation for these values state it matches the logic of `path.Match`, however in reality it's actually a prefix based match.

Updating the regex to allow for either an exact match, or a match where the configured value is a prefix of the package, when a `/` is added.

Additionally, strip any trailing `/`'s from the configured value, as this matches the logic that Go takes when matching.

Fixes renovatebot#13138
    Matthew Palmer committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    ff70e88 View commit details
    Browse the repository at this point in the history