Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changelogs): Add github-changelog and gitlab-changelog hosttypes #13695

Merged
merged 6 commits into from Feb 2, 2022

Conversation

rv2673
Copy link
Contributor

@rv2673 rv2673 commented Jan 20, 2022

Changes:

Behaviour changes

  • Make it possible to apply hostRules to changelog lookups.

Code changes

  • Introduce hostTypes for gitlab and github changelog lookups, so (specific) hostRules can be applied.
  • Add those types to the existing hostRule fallback mechanism for gitlab and github respectively

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/datasource/gitlab-packages/index.ts Outdated Show resolved Hide resolved
@rv2673 rv2673 requested a review from viceice January 21, 2022 20:01
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs deconflicting

@rv2673 rv2673 requested a review from viceice January 30, 2022 18:01
@viceice viceice changed the title fix(changelogs): Add changelog hosttypes to make feat(changelogs): Add changelog hosttypes Feb 1, 2022
@viceice viceice changed the title feat(changelogs): Add changelog hosttypes feat(changelogs): Add github-changelog and gitlab-changelog hosttypes Feb 1, 2022
@viceice viceice requested a review from rarkins February 1, 2022 07:52
@rarkins
Copy link
Collaborator

rarkins commented Feb 1, 2022

I don't like this, but it solves the problem and we don't have a better solution for now

@rarkins rarkins enabled auto-merge (squash) February 1, 2022 07:54
@rarkins rarkins merged commit 000142e into renovatebot:main Feb 2, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.66.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differing behaviour retrieving gitlab-tags and releases between datasource and changelog
4 participants