New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(changelogs): Add github-changelog
and gitlab-changelog
hosttypes
#13695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changelogs from platform calls.
viceice
requested changes
Jan 20, 2022
viceice
reviewed
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs deconflicting
viceice
approved these changes
Feb 1, 2022
viceice
changed the title
fix(changelogs): Add changelog hosttypes to make
feat(changelogs): Add changelog hosttypes
Feb 1, 2022
viceice
changed the title
feat(changelogs): Add changelog hosttypes
feat(changelogs): Add Feb 1, 2022
github-changelog
and gitlab-changelog
hosttypes
I don't like this, but it solves the problem and we don't have a better solution for now |
🎉 This PR is included in version 31.66.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Behaviour changes
Code changes
Context:
Closes Differing behaviour retrieving gitlab-tags and releases between datasource and changelog #13497
Replaces fix(gitlab): Consistent urlencoding and call source specific hostType for gitlab (changelogs, packages, tags, releases) #13577(Same but with url encoding seperated out to different request, see discussions there) and fix(gitlab): Consistent urlencoding and call source specific hostType for gitlab (changelogs, packages, tags, releases) #13577
This PR should probably be merged after refactor(gitlab-changelog): Make url encoding consistent #13694
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: