Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gitlab-changelog): Make url encoding consistent #13694

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

rv2673
Copy link
Contributor

@rv2673 rv2673 commented Jan 20, 2022

Changes:

Behaviour changes

  • Slashes are now replaced by %2F instead of lowercases %2f.
  • Fully url encode repository name instead of only replacing slashes trough regex. Which means other to be escaped characters will now also be url encoded for changelog calls.

Code changes

  • Replace encoding function with builtin url encoding function.

Context:

The url encoding used in changelog calls is different than the url encoding in all other gitlab datasources, which use the builtin encoding function. This PR refactors the code so that this is consistent.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice merged commit c13b42c into renovatebot:main Jan 20, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.38.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

ademar59 pushed a commit to ademar59/renovate that referenced this pull request Jan 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants