minimum git version check not compatible with 2.33.0.windows.2

[japj]

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

29.32.5

Please select which platform you are using if self-hosting.

Azure DevOps Server

If you're self-hosting Renovate, tell us what version of the platform you run.

2020 Update 1.1

Describe the bug

When upgrading from Renovate from 29.32.5 to 29.36.2 it fails due to:

EXEC : error : Git version needs upgrading [C:\agent01\_work\33\s\RenovateBot\RenovateBot\RenovateBot.csproj]
         "detectedVersion": "2.33.0.windows.2",
         "minimumVersion": "2.33.0"

It seems like the additional .windows.2 is not handled correctly?

This is the git that is installed from VS2019 11.8

Relevant debug logs

Logs

EXEC : error : Git version needs upgrading [C:\agent01\_work\33\s\RenovateBot\RenovateBot\RenovateBot.csproj]
         "detectedVersion": "2.33.0.windows.2",
         "minimumVersion": "2.33.0"

Have you created a minimal reproduction repository?

No reproduction repository

[viceice]

renovate/lib/util/git/index.ts

Lines 170 to 182 in d65a1dd

	if (
	!(
	version &&
	(version === GIT_MINIMUM_VERSION ||
	semverCoerced.isGreaterThan(version, GIT_MINIMUM_VERSION))
	)
	) {
	logger.error(
	{ detectedVersion: version, minimumVersion: GIT_MINIMUM_VERSION },
	'Git version needs upgrading'
	);
	return false;
	}

Seems the condition is wrong, as version isn't equal and isn't greater

[rarkins]

We need to use equals():

renovate/lib/versioning/semver-coerced/index.ts

Lines 40 to 44 in e0aaab8

	function equals(a: string, b: string): boolean {
	const aCoerced = semver.coerce(a);
	const bCoerced = semver.coerce(b);
	return aCoerced && bCoerced ? semver.eq(aCoerced, bCoerced) : false;
	}

[renovate-release]

🎉 This issue has been resolved in version 31.49.1 🎉

The release is available on:

• GitHub release
• 31.49.1

Your semantic-release bot 📦🚀