Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(best practices): avoid boolean instead use is functions #16573

Merged
merged 3 commits into from Jul 15, 2022

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Drop full stop from end of line item
  • Add new recommendation to use is function instead of Boolean

Context

Requested by @viceice in:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Jul 14, 2022
@rarkins rarkins enabled auto-merge (squash) July 14, 2022 05:59
auto-merge was automatically disabled July 14, 2022 06:45

Head branch was pushed to by a user without write access

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice viceice enabled auto-merge (squash) July 15, 2022 10:35
@viceice viceice merged commit 6ae4a55 into renovatebot:main Jul 15, 2022
@HonkingGoose HonkingGoose deleted the patch-6 branch July 15, 2022 10:59
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.117.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants