Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(best practices): avoid boolean instead use is functions #16573

Merged
merged 3 commits into from
Jul 15, 2022
Merged

docs(best practices): avoid boolean instead use is functions #16573

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17c0931
docs(best practices): avoid boolean instead use is functions
HonkingGoose Jul 14, 2022
13d3b11
Update docs/development/best-practices.md
HonkingGoose Jul 14, 2022
4087853
Merge branch 'main' into patch-6
viceice Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/development/best-practices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ Follow these best practices when you're working on our code.
- Always add unit tests for full code coverage
- Only use `istanbul` comments for unreachable code coverage that is needed for `codecov` completion
- Use descriptive `istanbul` comments
- Avoid cast or prefer `x as T` instead of `<T>x` cast.
- Avoid cast or prefer `x as T` instead of `<T>x` cast
- Avoid `Boolean` instead use `is` functions, for example: `is.string`
HonkingGoose marked this conversation as resolved.
Show resolved Hide resolved

```ts
// istanbul ignore next: can never happen
Expand Down