New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: throw error if issue with git #16618
refactor: throw error if issue with git #16618
Conversation
@rarkins Should we throw error for all instances where we execute git commands these changes suffice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're going to wrap in a catch then you need to throw again after
- rethrow err where needed - robust err-catching in syncGit
Instead of so much error handling I think let's just add a git status command after clone and hope that it is enough to trigger the error early. |
🤞 |
🎉 This PR is included in version 32.119.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: