Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: throw error if issue with git #16618

Merged
merged 14 commits into from
Jul 18, 2022
Merged

refactor: throw error if issue with git #16618

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
54d78cf
throw error
RahulGautamSingh Jul 16, 2022
2e7977b
add catch to all git ommands
RahulGautamSingh Jul 16, 2022
98866c6
add istanbul
RahulGautamSingh Jul 16, 2022
4e78e2f
- remove unnecessary catch blocks
RahulGautamSingh Jul 16, 2022
8ae7e04
add more catch blocks
RahulGautamSingh Jul 16, 2022
ec60349
testing ignore statement
RahulGautamSingh Jul 16, 2022
a2820d3
add git status command
RahulGautamSingh Jul 17, 2022
6a6aa6a
fix comments
RahulGautamSingh Jul 17, 2022
7656520
fix formatting
RahulGautamSingh Jul 17, 2022
3c62ca0
catch at isBranchModified
RahulGautamSingh Jul 17, 2022
e79bc8d
catch inside syncGit only
RahulGautamSingh Jul 17, 2022
1ec1bbf
Merge branch 'main' into fix/git_init+issue
RahulGautamSingh Jul 17, 2022
e7850f5
Merge branch 'main' into fix/git_init+issue
rarkins Jul 18, 2022
3884352
Merge branch 'main' into fix/git_init+issue
RahulGautamSingh Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/util/git/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,14 @@ export async function syncGit(): Promise<void> {
const durationMs = Math.round(Date.now() - cloneStart);
logger.debug({ durationMs }, 'git clone completed');
}
config.currentBranchSha = (await git.raw(['rev-parse', 'HEAD'])).trim();
try {
config.currentBranchSha = (await git.raw(['rev-parse', 'HEAD'])).trim();
} catch (err) /* istanbul ignore next */ {
if (err.message?.includes('fatal: not a git repository')) {
throw new Error(REPOSITORY_CHANGED);
}
throw err;
}
if (config.cloneSubmodules) {
const submodules = await getSubmodules();
for (const submodule of submodules) {
Expand Down