Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix lint issues #16779

Merged
merged 5 commits into from Jul 26, 2022
Merged

refactor: fix lint issues #16779

merged 5 commits into from Jul 26, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 26, 2022 •
edited

Changes

  • use toplevel await for .mjs files (unflaged since node 14.8)
  • fix and comment eslint null issues

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added the ci:fulltest Run full test suite on all platforms label Jul 26, 2022
@viceice viceice requested a review from JamieMagee as a code owner July 26, 2022 06:28
@viceice viceice requested a review from rarkins July 26, 2022 06:28
rarkins
rarkins previously approved these changes Jul 26, 2022
View reviewed changes
viceice
viceice commented Jul 26, 2022
View reviewed changes
lib/renovate.ts Outdated Show resolved Hide resolved
@viceice viceice requested a review from rarkins July 26, 2022 06:53
@viceice viceice enabled auto-merge (squash) July 26, 2022 08:21
@viceice viceice merged commit 8270d55 into main Jul 26, 2022
@viceice viceice deleted the fix/lint branch July 26, 2022 08:32
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.130.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viceice @renovate-release @rarkins