Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/helm): add hostType for helm dependencies during artifactupdate #17583

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Sep 2, 2022

Changes

Adds hostType during search for host rules in the case of Helm registries and not only if looking up a Docker registry.

Context

Closes #17573

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor marked this pull request as ready for review September 2, 2022 09:00
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/helmv3/artifacts.ts Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) September 2, 2022 16:53
@viceice viceice merged commit e69a9ce into renovatebot:main Sep 2, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.188.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
@secustor secustor deleted the 17573-helm_lock branch October 8, 2022 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm lock repo auth for private github repositories
3 participants