Does not detect some Maven plugin dependencies

[SimonCockx]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

Renovate doesn't seem to detect all dependencies.

I just activated Renovate in this repository: https://github.com/REGnosys/rosetta-dsl

In the dashboard, I see for example that it detects the pom file inside the submodule com.regnosys.rosetta.rosetta, but it doesn't show the dependency on xtext-maven-plugin; see here (although it does detect dependencies on other plugins, such as exec-maven-plugin; see here). There are other dependencies like this that don't get detected.

Relevant debug logs

Gist: https://gist.github.com/SimonCockx/6087fa57fa026869f29b77f041acd342

Have you created a minimal reproduction repository?

No reproduction, but I have linked to a public repo where it occurs

[rarkins]

Please use github permalinks to link to exact lines within your public repo

[SimonCockx]

@rarkins Okay, added links to the lines of the deps in the pom.

[rarkins]

The one you show working has a literal version (3.1.0) while the non-working one has a variable (${xtextVersion}). I think that variable is from here? https://github.com/REGnosys/rosetta-dsl/blob/98c5cde1a9fd392c377a908dfe509072c7f5db69/pom.xml#L24

[SimonCockx]

Yes that's the one. Good catch. Are Maven properties not supported?

[rarkins]

I thought they were. Maybe it's related to the fact it's in a different/higher level POM. @zharinov any insights you can give?

[zharinov]

Seems like specifying parent path would solve the problem

<parent>
  <groupId>com.regnosys.rosetta</groupId>
  <artifactId>com.regnosys.rosetta.parent</artifactId>
  <version>0.0.0.master</version>
  <relativePath>../</relativePath>
</parent>

[SimonCockx]

@zharinov I added the relativePath here and let Renovate run again, but the dependency is still not detected. Log: https://gist.github.com/SimonCockx/08b3e4eb49cdb594925adf30367602c3

[renovate-release]

🎉 This issue has been resolved in version 34.8.1 🎉

The release is available on:

• GitHub release
• 34.8.1

Your semantic-release bot 📦🚀

[SimonCockx]

@zharinov That's great news, thanks for the fix! Is the <relativePath>../</relativePath> bit still necessary for this to work, or can I leave it out?

[zharinov]

I think it is still needed as the way for Renovate to know parent-child relations between pom files