New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/gomod): update indirect dependencies for Go Modules #19431
feat(manager/gomod): update indirect dependencies for Go Modules #19431
Conversation
136abb7
to
594f02a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want indirect dependencies to be updated by default? I thought the idea would be to set enabled=false by default so that it's possible to override that using packageRules
. And we'd also need to update the docs about that
a6317c4
to
37f6ceb
Compare
Sorry yeah that was a misinterpretation on my part! I've updated to add that back 👍 |
Just to clarify (because it's not easy to understand), |
Good to know, thanks! Do I need to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs an update to the gomod readme to explain:
- indirect dependencies aren't updated by default
- how to re-enable them to using a package rule, to get updates
To allow folks to update their indirect dependencies for Go modules, we can parse them as `depType: indirect`. This introduces a new `Package.enabled` field to allow disabling the packages, and re-enable packages after the fact. Closes renovatebot#19416, renovatebot#19430.
37f6ceb
to
4acbf52
Compare
Thanks for helping get this over the line 🙌 |
🎉 This PR is included in version 34.58.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
To allow folks to update their indirect dependencies for Go modules, we
can parse them as
depType: indirect
.This introduces a new
Package.enabled
field to allow disabling thepackages, and re-enable packages after the fact.
Closes #19416, #19430.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: