Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/gomod): resolve multi-line indirect dependencies #19442

Merged
merged 2 commits into from Dec 16, 2022
Merged

fix(manager/gomod): resolve multi-line indirect dependencies #19442

merged 2 commits into from Dec 16, 2022

Conversation

jamietanna
Copy link
Contributor

Changes

As noticed in #19440, the handling for indirect dependencies didn't
quite work when using a multi-line require block.

Closes #19440.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@jamietanna jamietanna force-pushed the defect/indirect branch 2 times, most recently from a17dbcd to 6ff7b71 Compare December 16, 2022 09:30
@jamietanna jamietanna mentioned this pull request Dec 16, 2022
Closed
rarkins
rarkins previously approved these changes Dec 16, 2022
View reviewed changes
@rarkins rarkins enabled auto-merge (squash) December 16, 2022 09:38
@jamietanna
Copy link
Contributor Author

Coverage is failing due to:

Screenshot 2022-12-16 at 10 01 09

From this line of code which has changed because we're now not triggering this when we've got an indirect

Thoughts on what's best to do here? Trying to think of what valid go.mods could trigger this

fix(manager/gomod): resolve multi-line indirect dependencies
c85c28e 
As noticed in renovatebot#19440, the handling for indirect dependencies didn't
quite work when using a multi-line `require` block.

As we're now no longer hitting the `No multi-line match` logging
statement when we're receiving an `indirect` dependency, we need to add
a test to exercise that for our coverage requirements, too.

Closes renovatebot#19440.
auto-merge was automatically disabled December 16, 2022 10:14

Head branch was pushed to by a user without write access

@rarkins
Copy link
Collaborator

rarkins commented Dec 16, 2022

Coverage is failing due to:

Screenshot 2022-12-16 at 10 01 09

From this line of code which has changed because we're now not triggering this when we've got an indirect

Thoughts on what's best to do here? Trying to think of what valid go.mods could trigger this

Would an empty line or a line with a comment work here? I guess it's ok to remove that else if anyway because it's only for a trace log

@jamietanna
Copy link
Contributor Author

I've managed to trigger it with an empty line, yep - happy to keep it as that, or remove it if you'd prefer?

@rarkins
Copy link
Collaborator

rarkins commented Dec 16, 2022

Keep as is, who knows if it can be useful for tracing in future

@rarkins rarkins enabled auto-merge (squash) December 16, 2022 11:24
@rarkins rarkins merged commit 67d1b98 into renovatebot:main Dec 16, 2022
@jamietanna jamietanna deleted the defect/indirect branch December 16, 2022 11:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

manager:gomod does not expose indirect dependencies in dryRun: extract
3 participants
@jamietanna @rarkins @renovate-release