Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): centralize sidecar image usage #19545

Merged
merged 2 commits into from Dec 23, 2022
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 23, 2022

Changes

Centralize sidecar docker image usage.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins December 23, 2022 09:11
@viceice
Copy link
Member Author

viceice commented Dec 23, 2022

tested at https://github.com/renovate-reproductions/dotnet-testing

DEBUG: Using docker to execute (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
       "image": "sidecar"
DEBUG: Resolved stable matching version (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
       "toolName": "dotnet",
       "constraint": undefined,
       "resolvedVersion": "7.0.101"
DEBUG: containerbaseDir is inside cacheDir (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
DEBUG: Resolved tag constraint (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
       "image": "hub.kriese.eu/renovate/sidecar"
DEBUG: Fetching Docker image: hub.kriese.eu/renovate/sidecar (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
DEBUG: Finished fetching Docker image hub.kriese.eu/renovate/sidecar@sha256:ea6a33764ea924cb6ef9bd374cd2436cedc542271ee9ab854d54482f4301440c (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
DEBUG: Executing command (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
       "command": "docker run --rm --name=renovate_sidecar --label=renovate_child -v \"/tmp/renovate/repos/github/renovate-reproductions/dotnet-testing\":\"/tmp/renovate/repos/github/renovate-reproductions/dotnet-testing\" -v \"/tmp/renovate/cache\":\"/tmp/renovate/cache\" -e NUGET_PACKAGES -e MSBUILDDISABLENODEREUSE -e TEST_KEY -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w \"/tmp/renovate/repos/github/renovate-reproductions/dotnet-testing\" hub.kriese.eu/renovate/sidecar bash -l -c \"install-tool dotnet 7.0.101 && dotnet nuget add source https://api.nuget.org/v3/index.json --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config && dotnet restore three-two-linear/three/three.csproj --force-evaluate --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config\""
DEBUG: exec completed (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
       "durationMs": 32060,
       "stdout": "installing v2 tool dotnet v7.0.101\ndotnet-install: Note that the intended use of this script is for Continuous Integration (CI) scenarios, where:\ndotnet-install: - The SDK needs to be installed without user interaction and without admin rights.\ndotnet-install: - The SDK installation doesn't need to persist across multiple CI runs.\ndotnet-install: To set up a development environment or to run apps, use installers rather than this script. Visit https://dotnet.microsoft.com/download to get the installer.\n\ndotnet-install: Attempting to download using primary link https://dotnetcli.azureedge.net/dotnet/Sdk/7.0.101/dotnet-sdk-7.0.101-linux-x64.tar.gz\ndotnet-install: Extracting zip from https://dotnetcli.azureedge.net/dotnet/Sdk/7.0.101/dotnet-sdk-7.0.101-linux-x64.tar.gz\ndotnet-install: Installed version is 7.0.101\ndotnet-install: Binaries of dotnet can be found in /opt/buildpack/tools/dotnet\ndotnet-install: Note that the script does not resolve dependencies during installation.\ndotnet-install: To check the list of dependencies, go to https://learn.microsoft.com/dotnet/core/install, select your operating system and check the \"Dependencies\" section.\ndotnet-install: Installation finished successfully.\nlinking tool dotnet v7.0.101\n.NET SDK:\n Version:   7.0.101\n Commit:    bb24aafa11\n\nRuntime Environment:\n OS Name:     ubuntu\n OS Version:  20.04\n OS Platform: Linux\n RID:         ubuntu.20.04-x64\n Base Path:   /opt/buildpack/tools/dotnet/sdk/7.0.101/\n\nHost:\n  Version:      7.0.1\n  Architecture: x64\n  Commit:       97203d38ba\n\n.NET SDKs installed:\n  7.0.101 [/opt/buildpack/tools/dotnet/sdk]\n\n.NET runtimes installed:\n  Microsoft.AspNetCore.App 7.0.1 [/opt/buildpack/tools/dotnet/shared/Microsoft.AspNetCore.App]\n  Microsoft.NETCore.App 7.0.1 [/opt/buildpack/tools/dotnet/shared/Microsoft.NETCore.App]\n\nOther architectures found:\n  None\n\nEnvironment variables:\n  DOTNET_ROOT       [/opt/buildpack/tools/dotnet]\n\nglobal.json file:\n  Not found\n\nLearn more:\n  https://aka.ms/dotnet/info\n\nDownload .NET:\n  https://aka.ms/dotnet/download\nInstalled v2 /usr/local/buildpack/tools/v2/dotnet.sh in 26 seconds\nskip cleanup, not a docker build: d2e2d3de7b79\nPackage source with Name: Package source 1 added successfully.\n  Determining projects to restore...\n  Restored /tmp/renovate/repos/github/renovate-reproductions/dotnet-testing/three-two-linear/three/three.csproj (in 2.3 sec).\n  Restored /tmp/renovate/repos/github/renovate-reproductions/dotnet-testing/three-two-linear/two/two.csproj (in 2.3 sec).\n  Restored /tmp/renovate/repos/github/renovate-reproductions/dotnet-testing/three-two-linear/one/one.csproj (in 2.3 sec).\n",
       "stderr": ""
DEBUG: Updated 1 package files (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
DEBUG: Updated 3 lock files (repository=renovate-reproductions/dotnet-testing, branch=renovate-test/three-two-linear-serilog-2.x)
       "updatedArtifacts": [
         "three-two-linear/one/packages.lock.json",
         "three-two-linear/two/packages.lock.json",
         "three-two-linear/three/packages.lock.json"
       ]

@viceice viceice enabled auto-merge (squash) December 23, 2022 09:26
@viceice viceice merged commit 73be295 into main Dec 23, 2022
@viceice viceice deleted the feat/unify-docker-image branch December 23, 2022 09:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.71.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants