Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/sbt): Support for updating Scala 3 #19911

Merged
merged 9 commits into from Jan 23, 2023

Conversation

aktowns
Copy link
Contributor

@aktowns aktowns commented Jan 18, 2023

Changes

Checks if the current Scala version is 3 and if so uses the correct corresponding scala-library for determining the latest version.

This change only fixes 3.x updates if you're already on 3.x (so 2 -> 3 isn't offered).

Context

The underlying scala-library name has changed for Scala 3, this breaks how updating the Scala version is currently handled in renovate. This causes version look ups for people on 3.x to be ignored.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@aktowns aktowns changed the title Scala 3 Support for updating Scala 3 Jan 18, 2023
@aktowns aktowns changed the title Support for updating Scala 3 fix: Support for updating Scala 3 Jan 18, 2023
@rarkins rarkins requested a review from zharinov January 19, 2023 05:29
zharinov
zharinov previously approved these changes Jan 19, 2023
@aktowns aktowns marked this pull request as ready for review January 19, 2023 23:18
@rarkins rarkins enabled auto-merge (squash) January 20, 2023 07:43
rarkins
rarkins previously approved these changes Jan 20, 2023
@viceice viceice disabled auto-merge January 20, 2023 07:50
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2-v3 upgrade can be handled by our replace feature

lib/modules/manager/sbt/extract.spec.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Jan 20, 2023

v2-v3 upgrade can be handled by our replace feature

I didn't think so because packageName is provided by our extract and is not embedded in the package file.

@aktowns aktowns dismissed stale reviews from rarkins and zharinov via 3831833 January 22, 2023 12:37
aktowns and others added 2 commits January 22, 2023 23:37
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins requested a review from viceice January 23, 2023 06:21
rarkins
rarkins previously approved these changes Jan 23, 2023
@rarkins rarkins changed the title fix: Support for updating Scala 3 fix(manager/sbt): Support for updating Scala 3 Jan 23, 2023
@rarkins rarkins enabled auto-merge (squash) January 23, 2023 06:22
viceice
viceice previously approved these changes Jan 23, 2023
@rarkins rarkins merged commit 9eef71a into renovatebot:main Jan 23, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.109.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aktowns aktowns deleted the scala-3 branch January 24, 2023 04:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants