Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updateLockedDependency() for Yarn 2+ #21965

Closed
rarkins opened this issue May 4, 2023 · 1 comment · Fixed by #21966
Closed

Support updateLockedDependency() for Yarn 2+ #21965

rarkins opened this issue May 4, 2023 · 1 comment · Fixed by #21966
Assignees
Labels
manager:npm package.json files (npm/yarn/pnpm) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 4, 2023

What would you like Renovate to be able to do?

Support updateLockedDependency() gracefully for Yarn 2+.

Currently it results in quite ungraceful "Unexpected depNameConstraint" debug messages like:

{"level":20,"branch":"renovate/plasmicapp-react-web-0.x-lockfile","msg":"npm.updateLockedDependency: @plasmicapp/react-web@0.2.104 -> 0.2.205 [yarn.lock]","time":"2023-05-01T19:30:06.491Z"}
{"level":20,"branch":"renovate/plasmicapp-react-web-0.x-lockfile","depNameConstraint":"__metadata","entry":{"version":"6","cacheKey":"8"},"msg":"Unexpected depNameConstraint","time":"2023-05-01T19:30:06.580Z"}

If you have any ideas on how this should be implemented, please tell us here.

We do not need to be able to actually update the locked dependency, but we should be able to gracefully detect if it's already updated.

Today our getLockedDependencies() function is called prior to us checking if it's Yarn 2. It's probably best that we can gracefully parse that.

Is this a feature you are interested in implementing yourself?

No

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:npm package.json files (npm/yarn/pnpm) status:ready labels May 4, 2023
@rarkins rarkins self-assigned this May 4, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 35.86.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:npm package.json files (npm/yarn/pnpm) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants