Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docker registries that don't issue Docker-Content-Digest headers #2315

Closed
nbyl opened this issue Jul 26, 2018 · 2 comments · Fixed by #2316
Closed

Support Docker registries that don't issue Docker-Content-Digest headers #2315

nbyl opened this issue Jul 26, 2018 · 2 comments · Fixed by #2316

Comments

@nbyl
Copy link
Contributor

nbyl commented Jul 26, 2018

What would you like Renovate to be able to do?
The docker digest feature is really helpful to update base images, when the contents of a docker tag changes. The implementation of the retrieval of the current digest is based in the Docker-Content-Digest header. According to the offical documentation this header may be added. One example which does not add this header is RedHats registry at registry.access.redhat.com. For these registries renovate should have a fallback.

Describe the solution you'd like
If would like to use the blueprint of tools like the mechanism of skopeo to build a more resilient way of retrieving this digest.

Describe alternatives you've considered
An alternative would be to download the image and retrieve it from the local docker daemon. This is a pretty big overhead.

I will be working on this feature at my fork to see if this a possible way to go.

@rarkins
Copy link
Collaborator

rarkins commented Jul 26, 2018

For my hosted app, I don’t want to download entire images just to get the digest. For self hosted I suppose we could enable this behind an admin feature flag, but ideally there’s a better way!

rarkins pushed a commit that referenced this issue Jul 30, 2018
…ing (#2316)

As mentioned in #2315 some docker registries don't support the digest header. This PR falls back to parsing the resulting manifest if the header is present.

Closes #2315
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 13.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants