feat(platform/gitlab): Allow custom delay for pipeline status via experimental variable #23239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erimental variable Renovate's external commit status, `renovate/stability-days`, ends up creating a duplicate pipeline for Merge Requests when GitLab doesn't create the "actual" pipeline for a commit fast enough. This was previously worked around with a 1000ms delay but even that isn't enough in some cases -> allow customizing it via an experimental variable, `RENOVATE_X_GITLAB_BRANCH_STATUS_DELAY`.
rarkins
approved these changes
Jul 7, 2023
|
🎉 This PR is included in version 36.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add new experimental variable,
RENOVATE_X_GITLAB_BRANCH_STATUS_DELAY, to allow users to control the delay between Renovate pushing a commit to a branch and setting its status (whenminimumReleaseAge/stabilityDaysis used) to further combat race conditions when a slow GitLab instance doesn't react fast enough, causing duplicate pipelines.Defaults to previous 1s delay if not set.
Context
Renovate's external commit status,
renovate/stability-days, ends up creating a duplicate pipeline for Merge Requests when GitLab doesn't create the "actual" pipeline for a commit fast enough. This was previously worked around with a 1000ms delay but even that isn't enough in some cases -> allow customizing it via an experimental variable,RENOVATE_X_GITLAB_BRANCH_STATUS_DELAY.Discussion: #23132
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: