fileFilters is not defaulting to '**/*' as documented

[rarkins]

Discussed in #23463

^{Originally posted by anomiex July 19, 2023}

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us what version of Renovate you run.

36.13.2

If you're self-hosting Renovate, select which platform you are using.

github.com

Was this something which used to work for you, and then stopped?

I am trying to get this working for the first time

Describe the problem

PR #23126 supposedly changed the fileFilters option for postUpgradeTasks to default to matching everything. Specifically, the default is supposed to be '**/*'. This does not appear to be working.

Minimal reproduction repo: https://github.com/anomiex/renovate-test/

When I explicitly set fileFilters and ran renovate, it created the PR with the added file as expected.

When I removed fileFilters and ran it again, the added file was not included in the PR.

Relevant debug logs

Logs with `fileFilters` set

DEBUG: Executed post-upgrade task (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
       "dep": "chalk",
       "cmd": ".github/files/renovate-post-upgrade-run.sh renovate-sh/chalk-5.x",
       "stderr": "",
       "stdout": "Creating file changelog/renovate-sh-chalk-5.x\n"
DEBUG: Post-upgrade file saved (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
       "dep": "chalk",
       "file": "package.json",
       "pattern": "**/*"
DEBUG: Post-upgrade file saved (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
       "dep": "chalk",
       "file": "pnpm-lock.yaml",
       "pattern": "**/*"
DEBUG: Post-upgrade file saved (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
       "dep": "chalk",
       "file": "changelog/renovate-sh-chalk-5.x",
       "pattern": "**/*"
DEBUG: Getting comments for #17 (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: Found 0 comments (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: isBranchConflicted(master, renovate-sh/chalk-5.x) (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: branch.isConflicted(): using git to calculate (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: Setting git author name: Renovate Bot (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: Setting git author email: bot@renovateapp.com (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: branch.isConflicted(): false (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: 3 file(s) to commit (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: Preparing files for committing to branch renovate-sh/chalk-5.x (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: git commit (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
       "deletedFiles": [],
       "ignoredFiles": [],
       "result": {
         "author": null,
         "branch": "renovate-sh/chalk-5.x",
         "commit": "fe68a1c2b28a5913d0275d5f7f613ae98aa29206",
         "root": false,
         "summary": {"changes": 3, "insertions": 6, "deletions": 5}
       }

Logs with `fileFilters` not set

DEBUG: Executed post-upgrade task (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
       "dep": "chalk",
       "cmd": ".github/files/renovate-post-upgrade-run.sh renovate-sh/chalk-5.x",
       "stderr": "",
       "stdout": "Creating file changelog/renovate-sh-chalk-5.x\n"
DEBUG: Getting comments for #17 (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: Found 0 comments (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: isBranchConflicted(master, renovate-sh/chalk-5.x) (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: branch.isConflicted(): using git to calculate (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: Setting git author name: Renovate Bot (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: Setting git author email: bot@renovateapp.com (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: branch.isConflicted(): false (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: 2 file(s) to commit (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: Preparing files for committing to branch renovate-sh/chalk-5.x (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
DEBUG: git commit (repository=anomiex/renovate-test, branch=renovate-sh/chalk-5.x)
       "deletedFiles": [],
       "ignoredFiles": [],
       "result": {
         "author": null,
         "branch": "renovate-sh/chalk-5.x",
         "commit": "e7a90d786a6180ed01461d136f7b183424b3aa69",
         "root": false,
         "summary": {"changes": 2, "insertions": 5, "deletions": 5}
       }

Have you created a minimal reproduction repository?

I have linked to a minimal reproduction in the description above

[renovate-release]

🎉 This issue has been resolved in version 36.43.2 🎉

The release is available on:

• GitHub release
• 36.43.2

Your semantic-release bot 📦🚀