Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker release notes #2395

Closed
rarkins opened this issue Aug 16, 2018 · 4 comments · Fixed by #2907
Closed

Docker release notes #2395

rarkins opened this issue Aug 16, 2018 · 4 comments · Fixed by #2907
Labels
manager:dockerfile Dockerfile files priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Aug 16, 2018

  1. datasource returns GitHub source repo
  2. unify docker Pr body template with default
@rarkins rarkins added manager:dockerfile Dockerfile files type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people ready labels Aug 16, 2018
@rarkins
Copy link
Collaborator Author

rarkins commented Aug 16, 2018

Because docker registries have no metadata for source repo, I can’t think of any solution except hardcoding mappings within Renovate from docker image to GitHub repo. Also in many cases the user probably prefers release notes from the true source (eg node.js repo) than the image source/wrapper.

@mxey
Copy link
Contributor

mxey commented Oct 12, 2018

What would be better than nothing is checking if there's a matching GitHub repository (or a Gitlab repository on a configurable list of Gitlab instances?) and using that, because often the names line up.

For example:

  • the Docker image quay.io/coreos/prometheus-operatorcomes from GitHub repository https://github.com/coreos/prometheus-operator.
  • When using Gitlab's included Docker Registry, the paths will match, just the domain will be different. Image docker-registry.example.com/foo/bar will come from repository gitlab.example.com/foo/bar.

I also wouldn't mind configuring a list of patterns and mappings once, and then not have to go hunt for release notes anymore. For example, a list of regular expressions that turns the image names into repository URLs. That would cover more unusual registries like k8s.gcr.io

In addition, the Label Schema for Docker images has a label vcs-url to reference the Git repository that the image is built from.

The Docker Hub also supports automatic builds where you can find a link to the source repository on the page for the Docker image.

@rarkins
Copy link
Collaborator Author

rarkins commented Oct 12, 2018

First step we should support that vcs-url schema in case anyone's using it.

Next step is we can code in some known mappings (guesses).

Final step would be to allow manual overrides like we have for npm and pypi.

Note: I'm considering to move this manual mapping into lib/datasource/index.js to avoid reimplementing it in each individual datasoure.

mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 6, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 6, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 10, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 11, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 11, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 22, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 22, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 22, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 22, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 22, 2018
mikebryant added a commit to mikebryant/renovate that referenced this issue Dec 22, 2018
@rarkins rarkins removed the ready label Mar 7, 2019
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:dockerfile Dockerfile files priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants