feat(manager/asdf): add support for java semeru and semeru-jre #25063

MPV · 2023-10-05T13:36:27Z

Changes

This adds support for the asdf java semeru.

Context

This has been discussed before in at least the following issues:

Support more Java distributions for asdf .tool-version file #19183

Similar to what was recently done
(for temurin) in:

feat(manager/asdf): add support for java temurin and temurin-jre. #22504

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

MPV · 2023-10-05T13:37:12Z

For example, here's the currently existing asdf versions for semeru:

$ asdf list-all java | grep 'semeru'
semeru-jre-openj9-8u302-b08_openj9-0.27.0
semeru-jre-openj9-8u312-b07_openj9-0.29.0
semeru-jre-openj9-8u322-b06_openj9-0.30.0
semeru-jre-openj9-8u332-b09_openj9-0.32.0
semeru-jre-openj9-8u345-b01_openj9-0.33.1
semeru-jre-openj9-8u362-b09_openj9-0.36.0
semeru-jre-openj9-8u372-b07_openj9-0.38.0
semeru-jre-openj9-8u382-b05_openj9-0.40.0
semeru-jre-openj9-11.0.12+7_openj9-0.27.0
semeru-jre-openj9-11.0.13+8_openj9-0.29.0
semeru-jre-openj9-11.0.14+9_openj9-0.30.0
semeru-jre-openj9-11.0.14.1+1_openj9-0.30.1
semeru-jre-openj9-11.0.15+10_openj9-0.32.0
semeru-jre-openj9-11.0.16+8_openj9-0.33.0
semeru-jre-openj9-11.0.16.1+1_openj9-0.33.1
semeru-jre-openj9-11.0.17+8_openj9-0.35.0
semeru-jre-openj9-11.0.18+10_openj9-0.36.1
semeru-jre-openj9-11.0.19+7_openj9-0.38.0
semeru-jre-openj9-11.0.20+8_openj9-0.40.0
semeru-jre-openj9-11.0.20.1+1_openj9-0.40.0
semeru-jre-openj9-16.0.2+7_openj9-0.27.0
semeru-jre-openj9-17.0.1+12_openj9-0.29.1
semeru-jre-openj9-17.0.2+8_openj9-0.30.0
semeru-jre-openj9-17.0.3+7_openj9-0.32.0
semeru-jre-openj9-17.0.4+8_openj9-0.33.0
semeru-jre-openj9-17.0.4.1+1_openj9-0.33.1
semeru-jre-openj9-17.0.5+8_openj9-0.35.0
semeru-jre-openj9-17.0.6+10_openj9-0.36.0
semeru-jre-openj9-17.0.7+7_openj9-0.38.0
semeru-jre-openj9-17.0.8+7_openj9-0.40.0
semeru-jre-openj9-17.0.8.1+1_openj9-0.40.0
semeru-jre-openj9-_openj9-
semeru-openj9-8u302-b08_openj9-0.27.0
semeru-openj9-8u312-b07_openj9-0.29.0
semeru-openj9-8u322-b06_openj9-0.30.0
semeru-openj9-8u332-b09_openj9-0.32.0
semeru-openj9-8u345-b01_openj9-0.33.1
semeru-openj9-8u362-b09_openj9-0.36.0
semeru-openj9-8u372-b07_openj9-0.38.0
semeru-openj9-8u382-b05_openj9-0.40.0
semeru-openj9-11.0.12+7_openj9-0.27.0
semeru-openj9-11.0.13+8_openj9-0.29.0
semeru-openj9-11.0.14+9_openj9-0.30.0
semeru-openj9-11.0.14.1+1_openj9-0.30.1
semeru-openj9-11.0.15+10_openj9-0.32.0
semeru-openj9-11.0.16+8_openj9-0.33.0
semeru-openj9-11.0.16.1+1_openj9-0.33.1
semeru-openj9-11.0.17+8_openj9-0.35.0
semeru-openj9-11.0.18+10_openj9-0.36.1
semeru-openj9-11.0.19+7_openj9-0.38.0
semeru-openj9-11.0.20+8_openj9-0.40.0
semeru-openj9-11.0.20.1+1_openj9-0.40.0
semeru-openj9-16.0.2+7_openj9-0.27.0
semeru-openj9-17.0.1+12_openj9-0.29.1
semeru-openj9-17.0.2+8_openj9-0.30.0
semeru-openj9-17.0.3+7_openj9-0.32.0
semeru-openj9-17.0.4+8_openj9-0.33.0
semeru-openj9-17.0.4.1+1_openj9-0.33.1
semeru-openj9-17.0.5+8_openj9-0.35.0
semeru-openj9-17.0.6+10_openj9-0.36.0
semeru-openj9-17.0.7+7_openj9-0.38.0
semeru-openj9-17.0.8+7_openj9-0.40.0
semeru-openj9-17.0.8.1+1_openj9-0.40.0
semeru-openj9-_openj9-

lib/modules/manager/asdf/extract.spec.ts

lib/modules/manager/asdf/upgradeable-tooling.ts

...for `currentValue` to match the test data.

Drop `<openj9>` regex capture group. Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

MPV · 2023-10-10T08:11:54Z

@viceice could you take another look?

viceice · 2023-10-10T15:20:54Z

use the re-request GitHub button besides the reviewers

MPV · 2023-10-10T19:59:28Z

use the re-request GitHub button besides the reviewers

Thanks @viceice, that's done now.

MPV · 2023-10-16T08:36:06Z

@viceice I ran prettier now too, so the PR should be good to go — could you take a look?

secustor · 2023-11-01T08:06:12Z

prettier still fails

https://github.com/renovatebot/renovate/blob/main/.github/contributing.md

MPV · 2023-11-01T08:50:48Z

@secustor Thanks, should be fixed properly now (as I ran pnpm prettier-fix this time).

secustor

Please read the Contributor guide and do not ping maintainers

https://github.com/renovatebot/renovate/blob/main/.github/contributing.md

renovate-release · 2023-11-01T09:48:53Z

🎉 This PR is included in version 37.39.0 🎉

The release is available on:

GitHub release
37.39.0

Your semantic-release bot 📦🚀

viceice

__

viceice · 2023-11-01T17:37:14Z

lib/modules/manager/asdf/upgradeable-tooling.ts

@@ -261,6 +261,26 @@ export const upgradeableTooling: Record<string, ToolingDefinition> = {
          currentValue: adoptOpenJreMatches.version,
        };
      }
+      const semeruJdkMatches = version.match(
+        /^semeru-openj9-(?<version>\d\S+)_openj9-(?<openj9>\d\S+)/


Suggested change

/^semeru-openj9-(?<version>\d\S+)_openj9-(?<openj9>\d\S+)/

/^semeru-openj9-(?<version>\d\S+)_openj9-(?<openj9>\d\S+)/

this will create invalid PR's when openj9 version changes.

Ouch, yes that's unfortunate.

Do you have any ideas how we might solve this?

Here's what Scoop does, could we do something similar?

https://github.com/ScoopInstaller/Java/blob/master/bucket/semeru-lts-jre.json#L18-L19

I.e. make use of:

https://github.com/ibmruntimes/semeru17-binaries/releases

https://github.com/ibmruntimes/semeru11-binaries/releases

https://github.com/ibmruntimes/semeru8-binaries/releases

this isn't easily solvable, we should revert this PR until we've a proper working datasource / versioning for this.

viceice · 2023-11-01T17:37:46Z

lib/modules/manager/asdf/upgradeable-tooling.ts

+        };
+      }
+      const semeruJreMatches = version.match(
+        /^semeru-jre-openj9-(?<version>\d\S+)_openj9-\d\S+/


…atebot#25063) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

feat(manager/asdf): add support for java semeru and semeru-jre

384f5d1

viceice reviewed Oct 5, 2023

View reviewed changes

lib/modules/manager/asdf/extract.spec.ts Outdated Show resolved Hide resolved

lib/modules/manager/asdf/extract.spec.ts Outdated Show resolved Hide resolved

lib/modules/manager/asdf/upgradeable-tooling.ts Outdated Show resolved Hide resolved

MPV and others added 3 commits October 9, 2023 15:43

Update lib/modules/manager/asdf/extract.spec.ts

9e9e834

...for `currentValue` to match the test data.

Update lib/modules/manager/asdf/extract.spec.ts

76109ed

Update lib/modules/manager/asdf/upgradeable-tooling.ts

d5b5025

Drop `<openj9>` regex capture group. Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

MPV requested a review from viceice October 10, 2023 19:58

Run Prettier

9cd9b24

Run pnpm prettier-fix

b35c8d0

secustor approved these changes Nov 1, 2023

View reviewed changes

secustor added this pull request to the merge queue Nov 1, 2023

Merged via the queue into renovatebot:main with commit 25292f0 Nov 1, 2023
36 checks passed

viceice reviewed Nov 1, 2023

View reviewed changes

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023

feat(manager/asdf): add support for java semeru and semeru-jre (renov…

3d8b0ad

…atebot#25063) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(manager/asdf): add support for java semeru and semeru-jre #25063

feat(manager/asdf): add support for java semeru and semeru-jre #25063

MPV commented Oct 5, 2023

MPV commented Oct 5, 2023

MPV commented Oct 10, 2023

viceice commented Oct 10, 2023

MPV commented Oct 10, 2023

MPV commented Oct 16, 2023

secustor commented Nov 1, 2023 •

edited

MPV commented Nov 1, 2023

secustor left a comment

renovate-release commented Nov 1, 2023

viceice left a comment

viceice Nov 1, 2023

MPV Nov 1, 2023

MPV Nov 1, 2023

viceice Nov 1, 2023

viceice Nov 1, 2023

	/^semeru-openj9-(?<version>\d\S+)_openj9-(?<openj9>\d\S+)/
	/^semeru-openj9-(?<version>\d\S+)_openj9-(?<openj9>\d\S+)/

feat(manager/asdf): add support for java semeru and semeru-jre #25063

feat(manager/asdf): add support for java semeru and semeru-jre #25063

Conversation

MPV commented Oct 5, 2023

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

MPV commented Oct 5, 2023

MPV commented Oct 10, 2023

viceice commented Oct 10, 2023

MPV commented Oct 10, 2023

MPV commented Oct 16, 2023

secustor commented Nov 1, 2023 • edited

MPV commented Nov 1, 2023

secustor left a comment

Choose a reason for hiding this comment

renovate-release commented Nov 1, 2023

viceice left a comment

Choose a reason for hiding this comment

viceice Nov 1, 2023

Choose a reason for hiding this comment

MPV Nov 1, 2023

Choose a reason for hiding this comment

MPV Nov 1, 2023

Choose a reason for hiding this comment

viceice Nov 1, 2023

Choose a reason for hiding this comment

viceice Nov 1, 2023

Choose a reason for hiding this comment

secustor commented Nov 1, 2023 •

edited