feat(manager/asdf): add support for java temurin and temurin-jre. #22504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
viceice
reviewed
May 30, 2023
jannylund
force-pushed
the
feat-support-asdf-java-temurin
branch
from
3448cf2
to
04388e6
Compare
|
Please do not force push and needs prettifying |
jannylund
force-pushed
the
feat-support-asdf-java-temurin
branch
from
04388e6
to
5e747d1
Compare
Oops, sorry. Did not notice that was not allowed. I already force-pushed the prettify change. 🤐 |
viceice
approved these changes
Jun 1, 2023
|
🎉 This PR is included in version 35.108.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds support for the asdf java temurin.
Context
This has been discussed before in at least the following issues:
temurinas a Java distribution name instead ofadoptopenjdkin asdf .tool-version #19184Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: