Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(default presets): remove default:onlyNpm preset, improve descriptions #25644

Merged
merged 5 commits into from Nov 8, 2023
Merged

feat(default presets): remove default:onlyNpm preset, improve descriptions #25644

merged 5 commits into from Nov 8, 2023

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Nov 8, 2023 •
edited

Changes

  • Remove the old onlyNpm preset
  • Improve description for some default presets

Context

Drive-by PR, not closing any issue with this.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

HonkingGoose
HonkingGoose commented Nov 8, 2023
View reviewed changes
lib/config/presets/internal/default.ts Outdated Show resolved Hide resolved
lib/config/presets/internal/default.ts Outdated Show resolved Hide resolved
@HonkingGoose HonkingGoose marked this pull request as draft November 8, 2023 10:46
@HonkingGoose HonkingGoose changed the title chore(default presets): improve descriptions feat(default presets): remove onlyNpm preset, improve descriptions Nov 8, 2023
@HonkingGoose HonkingGoose changed the title feat(default presets): remove onlyNpm preset, improve descriptions feat(default presets): remove default:onlyNpm preset, improve descriptions Nov 8, 2023
@HonkingGoose HonkingGoose marked this pull request as ready for review November 8, 2023 11:10
@rarkins rarkins added this pull request to the merge queue Nov 8, 2023
Merged via the queue into renovatebot:main with commit f1fa4c1 Nov 8, 2023
36 checks passed
@HonkingGoose HonkingGoose deleted the chore/improve-default-preset-decription branch November 8, 2023 12:53
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.51.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@HonkingGoose @jon4hz
feat(default presets): remove default:onlyNpm preset, improve descr…
0813f07 
…iptions (renovatebot#25644)
bchew added a commit to Adslot/renovate-config-adslot that referenced this pull request Nov 16, 2023
@bchew
fix: fix deprecated onlyNpm default preset
700435e 
renovatebot/renovate#25644
@bchew bchew mentioned this pull request Nov 16, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HonkingGoose @renovate-release @rarkins