Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(default presets): remove default:onlyNpm preset, improve descriptions #25644

Merged
merged 5 commits into from
Nov 8, 2023
Merged

feat(default presets): remove default:onlyNpm preset, improve descriptions #25644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59bf734
chore(default presets): improve descriptions
HonkingGoose Nov 8, 2023
ab66907
Fix grammar
HonkingGoose Nov 8, 2023
02bfce5
Fix snapshot
HonkingGoose Nov 8, 2023
0e03c74
Remove default:onlyNpm preset
HonkingGoose Nov 8, 2023
6fb617a
Merge branch 'main' into chore/improve-default-preset-decription
HonkingGoose Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/config/presets/__snapshots__/index.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ exports[`config/presets/index resolvePreset migrates automerge in presets 1`] =
"automergeType": "pr",
"branchPrefix": "renovate/",
"description": [
"Prefix \`renovate/\` to all branch names.",
"Add the \`renovate/\` prefix to all branch names.",
"Use semantic commit type \`fix\` for dependencies and \`chore\` for all others if semantic commits are in use.",
"Require all status checks to pass before any automerging.",
"Pin dependency versions for \`devDependencies\` and retain SemVer ranges for others.",
Expand Down
1 change: 1 addition & 0 deletions lib/config/presets/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export const removedPresets: Record<string, string | null> = {
'default:app': 'config:js-app',
'default:js-app': 'config:js-app',
'default:library': 'config:js-lib',
'default:onlyNpm': null,
rarkins marked this conversation as resolved.
Show resolved Hide resolved
'default:unpublishSafe': 'npm:unpublishSafe',
'helpers:oddIsUnstable': null,
'helpers:oddIsUnstablePackages': null,
Expand Down
18 changes: 3 additions & 15 deletions lib/config/presets/internal/default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const presets: Record<string, Preset> = {
description: 'Disable Renovate Dependency Dashboard creation.',
},
disableDevDependencies: {
description: 'Do not renovate `devDependencies` versions/ranges.',
description: 'Do not update `devDependencies` versions/ranges.',
packageRules: [
{
enabled: false,
Expand Down Expand Up @@ -180,7 +180,7 @@ export const presets: Record<string, Preset> = {
},
},
disablePeerDependencies: {
description: 'Do not renovate `peerDependencies` versions/ranges.',
description: 'Do not update `peerDependencies` versions/ranges.',
packageRules: [
{
enabled: false,
Expand Down Expand Up @@ -361,18 +361,6 @@ export const presets: Record<string, Preset> = {
enabled: true,
},
},
onlyNpm: {
description: 'Renovate only npm dependencies.',
'docker-compose': {
enabled: false,
},
dockerfile: {
enabled: false,
},
meteor: {
enabled: false,
},
},
pathSemanticCommitType: {
description:
'Use semanticCommitType `{{arg0}}` for all package files matching path `{{arg1}}`.',
Expand Down Expand Up @@ -497,7 +485,7 @@ export const presets: Record<string, Preset> = {
},
renovatePrefix: {
branchPrefix: 'renovate/',
description: 'Prefix `renovate/` to all branch names.',
description: 'Add the `renovate/` prefix to all branch names.',
},
respectLatest: {
description: 'Upgrade versions up to the "latest" tag in the npm registry.',
Expand Down