fix(reconfigure/pr): find reconfigure pr separately

[RahulGautamSingh]

Changes

• Added a new findReconfigurePr function in supported platforms (GitHub, GitLab, Gitea).
• For GitHub and GitLab, these functions now make separate GET requests to fetch PRs based on the source branch name.
• For Gitlab: Modified its toRenovatePR function to ensure that reconfigure PRs are not filtered out from the list of PRs fetched.

Context

Closes: #25754

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[RahulGautamSingh]

Test Runs:

To do this, I created two accounts on each platform: one user account and one bot account. I then added the bot account as a member/collaborator on the test repositories.

I then proceeded to create a new onboarded repository and a 'reconfigure' branch, along with a corresponding pull request using the user account.

Finally, I ran Renovate against all the repositories using the bot account's token.

Gitlab - Github - Gitea - Bitbucket - Azure

BitbucketServer

[rarkins]

What's the reason for only certain platforms?

I think: some platforms retrieve every PR already and do filtering on the Renovate client-side. So for those we don't need a new function and can fall back to findPr()

[RahulGautamSingh]

What's the reason for only certain platforms?

Got mixed up a bit. Pushing them soon

I think: some platforms retrieve every PR already and do filtering on the Renovate client-side. So for those we don't need a new function and can fall back to findPr()

Since we have to add a new fn for github, and gitlab which will be available via the platform class. I thought it was cleaner to have the function in all platforms. And in the ones that don't need extra logic just pass it onto findPr from there.

// platform/gitea/index.ts

async function findReconfigurePr(branchName: string){
  return await findPr({ branchName });
},

// workers/repository/reconfigure/index.ts

const reconfigurePr = platform.findReconfigurePr(branchName);

Instead of adding an if-logic to handle this in the reconfigure logic.

// workers/repository/reconfigure/index.ts

let reconfigurePr: Pr|null = null;
switch(platform){
  case "github": reconfigurePr = platform.findReconfigurePr(branchName); break;
  case "gitlab": reconfigurePr = platform.findReconfigurePr(branchName); break;
  default: reconfigurePr = platform.findPr({ branchName, ...});
}

[rarkins]

You could check for the existence of platform.findReconfigurePr() - you don't need to embed platform-awareness into the worker layer

[RahulGautamSingh]

You could check for the existence of platform.findReconfigurePr() - you don't need to embed platform-awareness into the worker layer

Yes, missed that. Thanks.

[viceice]

otherwise LGTM

[renovate-release]

🎉 This PR is included in version 37.111.1 🎉

The release is available on:

• GitHub release
• 37.111.1

Your semantic-release bot 📦🚀