Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): custom status checks #26047

Merged
merged 21 commits into from Dec 14, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Allow users to set custom status check strings.

  • Added new config option statusCheckNames
  • Add validation for the new option such that only the 4 existing status check strings can be modified and new ones cannot be added

Context

Closes: #23530

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Nov 29, 2023

Test Runs:

  1. Uses default value
  2. Use custom string set by user
  3. Disables the status check if value is null or empty string

@RahulGautamSingh RahulGautamSingh requested review from HonkingGoose and removed request for HonkingGoose November 29, 2023 18:52
@RahulGautamSingh RahulGautamSingh marked this pull request as draft November 29, 2023 19:16
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 29, 2023 19:25
lib/config/types.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh requested review from viceice and removed request for viceice November 29, 2023 20:09
@RahulGautamSingh RahulGautamSingh marked this pull request as draft November 30, 2023 02:11
@RahulGautamSingh

This comment was marked as outdated.

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 30, 2023 03:19
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/status-checks.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/status-checks.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/status-checks.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/status-checks.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/status-checks.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 3 commits December 3, 2023 17:59
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Show resolved Hide resolved
lib/workers/repository/update/branch/artifacts.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/artifacts.ts Outdated Show resolved Hide resolved
rarkins and others added 3 commits December 4, 2023 12:11
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
lib/config/types.ts Outdated Show resolved Hide resolved
lib/config/validation.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/artifacts.spec.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Dec 12, 2023

@RahulGautamSingh there's a lot of unresolved conversations - can you take a look and resolve them where applicable?

viceice
viceice previously approved these changes Dec 14, 2023
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins added this pull request to the merge queue Dec 14, 2023
Merged via the queue into renovatebot:main with commit 3ed295c Dec 14, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.98.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

hersentino pushed a commit to hiventive/renovate that referenced this pull request Jan 9, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize Renovate's status check strings
5 participants