GitLabError: 404 Branch Not Found

[Jamesking56]

What Renovate type are you using?
Renovate Docker run via GitLab CI

Describe the bug
If you delete a branch in GitLab, it causes an error in renovate log:

WARN: Error getting PR branch (repository=<project>, dependencies=vue-router, branch=renovate/vue-router-3.x)
       "err": {
         "name": "GitLabError",
         "host": "gitlab.com",
         "hostname": "gitlab.com",
         "method": "GET",
         "path": "/api/v4/projects/<project>/repository/branches/renovate%2Fvue-router-3.x",
         "protocol": "https:",
         "url": "https://gitlab.com/api/v4/projects/<project>/repository/branches/renovate%2Fvue-router-3.x",
         "statusCode": 404,
         "statusMessage": "Not Found",
         "headers": {
           "server": "nginx",
           "date": "Mon, 08 Oct 2018 09:19:59 GMT",
           "content-type": "application/json",
           "content-length": "34",
           "connection": "close",
           "cache-control": "no-cache",
           "vary": "Origin",
           "x-content-type-options": "nosniff",
           "x-frame-options": "SAMEORIGIN",
           "x-request-id": "ba0f7a0a-b8d0-43e7-91ec-4550b58fc765",
           "x-runtime": "0.028301",
           "ratelimit-limit": "600",
           "ratelimit-observed": "3",
           "ratelimit-remaining": "597",
           "ratelimit-reset": "1538990459",
           "ratelimit-resettime": "Tue, 08 Oct 2018 09:20:59 GMT"
         },
         "body": {"message": "404 Branch Not Found"},
         "message": "404 Branch Not Found (404)",
         "stack": "GitLabError: 404 Branch Not Found (404)\n    at stream.catch.then.data (/usr/src/app/node_modules/gl-got/node_modules/got/index.js:182:13)\n    at <anonymous>\n    at process._tickCallback (internal/process/next_tick.js:189:7)"
       }

This causes the script to return a failure (return code 1)

To Reproduce
Steps to reproduce the behavior:

1. Get Renovate to make an MR
2. Close the MR and Delete the branch
3. Re-run renovate

Expected behavior
I would expect renovate to close the MR (if it hasn't been closed) and ignore that update.

[rarkins]

Doesn’t GitLab automatically close PRs when the associated branch disappears?

[Jamesking56]

@rarkins I don't think so no

[rarkins]

That's really strange then. A while back they changed behaviour which meant Renovate's own PRs got closed when it needs to delete a branch before pushing again. I don't understand how/why the behaviour would be different in this case. In short though: don't go deleting the branches unless you plan to close the MR too :)

[Jamesking56]

@rarkins Yeah I realise that now, the issue I now have is how do I stop it warning me on every run?

[rarkins]

@Jamesking56 if the problem is because a MR's branch was deleted and the MR remains open, can you just manually close or delete the MR?

[Jamesking56]

@rarkins The MR is closed. I closed the MR and clicked to delete the branch and now this warning always appears.

[rarkins]

@Jamesking56 in that case could you update/correct the reproduction steps? What you describe now doesn't match with the steps in the bug report.

[Jamesking56]

@rarkins updated

[rarkins]

Looking at the source code, I think this is a harmless situation (a closed PR is retrieve but its branch does not exist) so I am adding a fix to skip any logger warning in such cases.

[Jamesking56]

Thanks so much @rarkins

[renovate-bot]

🎉 This issue has been resolved in version 13.99.10 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀