Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workers/repository): Extract processUpdateArtifactResults method #27324

Merged

Conversation

not7cd
Copy link
Contributor

@not7cd not7cd commented Feb 15, 2024

Changes

A bit complex code that repeats after every updateArtifacts has been extracted to a single function. Section of updateArtifacts is a bit daunting and very nested. This should make it clearer to read.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@secustor secustor changed the title refactor: Extract processUpdateArtifactResults method refactor(workers/repository): Extract processUpdateArtifactResults method Feb 17, 2024
@secustor secustor added this pull request to the merge queue Feb 17, 2024
Merged via the queue into renovatebot:main with commit f9dc713 Feb 17, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.194.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants