Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle missing some upgrades? #2740

Closed
rarkins opened this issue Nov 4, 2018 · 2 comments
Closed

Gradle missing some upgrades? #2740

rarkins opened this issue Nov 4, 2018 · 2 comments
Labels
help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others

Comments

@rarkins
Copy link
Collaborator

rarkins commented Nov 4, 2018

@corecanarias can you help me look into this? This question is from my fork of telegram-images.

Here's the gradle log:

       The following dependencies have later release versions:
        - com.github.rubenlagus:TelegramBots [v2.3.5 -> 2.4.4.5]
        - cglib:cglib-nodep [3.1 -> 3.2.9]
        - com.github.ben-manes:gradle-versions-plugin [0.17.0 -> 0.20.0]
        - org.codehaus.groovy:groovy [2.4.7 -> 3.0.0-alpha-3]
        - org.objenesis:objenesis [2.1 -> 3.0.1]
        - org.spockframework:spock-core [1.0-groovy-2.4 -> 1.2-RC3-groovy-2.5]
        - org.springframework.boot:spring-boot-gradle-plugin [1.4.0.RELEASE -> 2.1.0.RELEASE]
        - org.springframework.boot:spring-boot-starter-jersey [1.4.0.RELEASE -> 2.1.0.RELEASE]

But we only create these:
image

These are missing:

com.github.ben-manes:gradle-versions-plugin [0.17.0 -> 0.20.0]
org.codehaus.groovy:groovy [2.4.7 -> 3.0.0-alpha-3]
org.springframework.boot:spring-boot-starter-jersey [1.4.0.RELEASE -> 2.1.0.RELEASE]

The first one is the one we inject, right? Should we be using the latest version of it?

groovy looks to be an "unstable" version so maybe that's why it's skipped? But then why are we upgrading spock-core to a stable version instead of 1.2-RC3-groovy-2.5?

Also I can see no reason for skipping spring-boot-starter-jersey's upgrade as we alreaduy upgrade spring-boot-starter-plugin.

@rarkins rarkins added help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others question labels Nov 4, 2018
@corecanarias
Copy link
Contributor

@rarkins Yep, that's weird. Let me take a look

@corecanarias
Copy link
Contributor

Ok, there are two things:

  • gradle-versions-plugin It's because we are using the recommended version for gradle-use-latest-versions-plugin 0.2.3 Last week they release a new version: 0.2.5 and now in the docs says using 0.20.0 Probably we would need a way to maintain this dependencies up to date as well. But not sure how, since this is an internal configuration of renovate. Maybe externalize it to the dockerfile? But that would introduce more complexity for someone that wants to run it without docker

  • For the other two dependencies, it's not updated because they are defined without versioning:

        compile('org.springframework.boot:spring-boot-starter-jersey')
        compile('org.codehaus.groovy:groovy')

This dependencies are selected based on spring-boot-gradle-plugin version. So they will automatically pick the latest version when this version changes.

@rarkins rarkins closed this as completed Nov 11, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others
Projects
None yet
Development

No branches or pull requests

2 participants