Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: support non-semver versions #28298

Open
rarkins opened this issue Apr 10, 2024 · 0 comments
Open

Composer: support non-semver versions #28298

rarkins opened this issue Apr 10, 2024 · 0 comments
Labels
manager:composer Composer (PHP) package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 10, 2024

Describe the proposed change(s).

Apparently composer/packagist packages are not limited to semver for example: https://semver.madewithlove.com/?package=shopware%2Fadministration

#28297 has been created to support such versions properly in composer versioning.

For this issue, we should check the existing version if it is semver-compatible and if not then switch to loose versioning. In cases where a non-semver locked version exists but composer.json uses a range syntax then we will need to skip it.

i.e.

  • If currentValue and lockedVersion are the same, non-semver version - valid loose versions - then switch to loose
  • If lockedVersion is non-semver and currentValue is a constraint, add a skipReason
@rarkins rarkins added type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people manager:composer Composer (PHP) package manager labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:composer Composer (PHP) package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant