Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset): group Testing Library packages together #28414

Merged
merged 6 commits into from Apr 15, 2024

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Apr 15, 2024

Changes

groups the packages from this kind of monorepo https://github.com/testing-library
See also https://www.npmjs.com/search?q=%40testing-library%2F

Context

I had renovate open one MR for @testing-library/react and one for @testing-library/dom and actually both of those were major upgrades that depend on each other -> need to be done together. So I thought of grouping them by default.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herndlm herndlm requested a review from rarkins April 15, 2024 13:05
@herndlm
Copy link
Contributor Author

herndlm commented Apr 15, 2024

sorry about the signed commits showing up as unverified. I recently enabled SSH signing, worked just fine for a privat gitlab, but github is somehow still unhappy with it. even though the ssh public key is trusted in my account, weird. the ssh fingerprint matches and I have no other ssh key on my system it could have used for signing
UPDATE: figured it out, github separates authentication and signing keys :)

Co-authored-by: Rhys Arkins <rhys@arkins.net>
@herndlm herndlm requested a review from rarkins April 15, 2024 14:34
@rarkins rarkins added this pull request to the merge queue Apr 15, 2024
Merged via the queue into renovatebot:main with commit dc7e803 Apr 15, 2024
35 checks passed
@herndlm herndlm deleted the patch-1 branch April 15, 2024 15:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants