-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preset): group Testing Library packages together #28414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry about the signed commits showing up as unverified. I recently enabled SSH signing, worked just fine for a privat gitlab, but github is somehow still unhappy with it. even though the ssh public key is trusted in my account, weird. the ssh fingerprint matches and I have no other ssh key on my system it could have used for signing |
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Changes
groups the packages from this kind of monorepo https://github.com/testing-library
See also https://www.npmjs.com/search?q=%40testing-library%2F
Context
I had renovate open one MR for
@testing-library/react
and one for@testing-library/dom
and actually both of those were major upgrades that depend on each other -> need to be done together. So I thought of grouping them by default.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: