Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOPROXY + pseudoversions: skip direct lookup fallback when @latest is known #28707

Closed
rarkins opened this issue Apr 28, 2024 · 1 comment · Fixed by #28708
Closed

GOPROXY + pseudoversions: skip direct lookup fallback when @latest is known #28707

rarkins opened this issue Apr 28, 2024 · 1 comment · Fixed by #28708
Assignees
Labels
datasource:go priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 28, 2024

Describe the proposed change(s).

If GOPROXY is used, and @v/list returns empty for a pseudo version while @latest returns a version, then use that version as the only version in order to skip the fallback to github.com lookups.

Example dependency:

require (
	k8s.io/utils v0.0.0-20230220204549-a5ecb0141aa5
)

https://proxy.golang.org/k8s.io/utils/@latest returns:

{"Version":"v0.0.0-20240423183400-0849a56e8f22","Time":"2024-04-23T18:34:00Z","Origin":{"VCS":"git","URL":"https://github.com/kubernetes/utils","Hash":"0849a56e8f2216ce029590a538a9b50f301a90ae"}}

In such a case there's no need to fall back to looking it up from github.com, instead we can use v0.0.0-20240423183400-0849a56e8f22 as the result.

@rarkins rarkins added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features datasource:go labels Apr 28, 2024
@rarkins rarkins self-assigned this Apr 28, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.327.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource:go priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants