Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log when _PROXY values detected #29191

Merged
merged 1 commit into from
May 21, 2024
Merged

chore: log when _PROXY values detected #29191

merged 1 commit into from
May 21, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 21, 2024

Changes

Log for each _PROXY env var found. Do not log the value in case it contains secrets.

Context

Aiming to make topics like #29190 easier to support.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested review from viceice and secustor May 21, 2024 14:47
@rarkins rarkins enabled auto-merge May 21, 2024 14:47
@rarkins rarkins added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@rarkins rarkins added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit e281931 May 21, 2024
37 checks passed
@rarkins rarkins deleted the chore/log-proxy branch May 21, 2024 18:48
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.371.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants