Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven handle parameterised repositories #3522

Closed
rarkins opened this issue Apr 10, 2019 · 2 comments · Fixed by #3533
Closed

Maven handle parameterised repositories #3522

rarkins opened this issue Apr 10, 2019 · 2 comments · Fixed by #3533
Assignees
@zharinov
Labels
manager:maven Maven (Java) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 10, 2019

Example: https://github.com/chanhosong/hivaasdatasimulator/blob/master/mappingtool/pom.xml

It includes an eclipse property:

	<properties>
		<tycho-version>0.22.0</tycho-version>
		<eclipse>http://download.eclipse.org/releases/kepler</eclipse>
	</properties>

And then the repositories field references it:

	<repositories>
		<repository>
			<id>kepler</id>
			<layout>p2</layout>
			<url>${eclipse}</url>
		</repository>
	</repositories>
@rarkins rarkins added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:maven Maven (Java) package manager labels Apr 10, 2019
@rarkins
Copy link
Collaborator Author

rarkins commented Apr 10, 2019

@zharinov maybe we can handle this simplest case, i.e. if the url is a single property and that property exists in the same file.. then replace it. Otherwise we should maybe warn if we find a url containing a property we can't replace.

@rarkins rarkins added the ready label Apr 10, 2019
@zharinov zharinov mentioned this issue Apr 11, 2019
Merged
@rarkins rarkins added review and removed ready labels Apr 11, 2019
rarkins pushed a commit that referenced this issue Apr 12, 2019
@zharinov @rarkins
feat(maven): Handle parameterised repositories (#3533)
336c944 
Closes #3522
@rarkins rarkins removed the review label Apr 12, 2019
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zharinov zharinov

Labels
manager:maven Maven (Java) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(maven): Handle parameterised repositories zharinov/renovate
3 participants
@zharinov @rarkins @renovate-bot