Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support maven-wrapper like gradle-wrapper #3566

Closed
BigMichi1 opened this issue Apr 19, 2019 · 7 comments · Fixed by #15660
Closed

support maven-wrapper like gradle-wrapper #3566

BigMichi1 opened this issue Apr 19, 2019 · 7 comments · Fixed by #15660
Assignees
Labels
help wanted Help is needed or welcomed on this issue new package manager New package manager support priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@BigMichi1
Copy link

What would you like Renovate to be able to do?
A lot of new projects which are using maven relay on the maven-wrapper (https://github.com/takari/maven-wrapper) so maven behaves in the same way like gradle. you don't need to install a maven locally, it's just calling ./mvnw and it will download the defined version in maven-wrapper.properties. So it would be really nice if there is also support for updating maven-wrapper. Maven wrapper consists of 4 files, 2 of them are stored in .mvn/wrapper/ directory the other two are the executables in the project root directory

  • ./mvn/wrapper/maven-wrapper.jar - downloading logic
  • ./mvn/wrapper/maven-wrapper.properties - contains the url and version of maven which should be used for the project
  • ./mvnw - linux executable
  • ./mvnw.cmd - windows executable

Describe the solution you'd like
solution should consist of two parts:

  • detection if new maven is available and update the version for maven just in the properties file
  • detection if new wrapper is available und update possibly all 4 files (exectables, properties file and download logic)

Describe alternatives you've considered
first thing can be achieved by manually changing the maven version number in maven-wrapper.properties
second thing can be also achieved by manually executing mvn -N io.takari:maven:0.7.6:wrapper -Dmaven=3.3.3 where the version of maven is pinned to the currently used on and a new version of the wrapper is specified

Additional context
maybe the logic from the gradle-wrapper check can be reused and extended to cover both situations for maven (gradle uses only one version for the wrapper and the distribution)

@rarkins rarkins added #java manager:maven Maven (Java) package manager type:feature Feature (new functionality) new package manager New package manager support labels Apr 19, 2019
@rarkins rarkins removed needs-requirements manager:maven Maven (Java) package manager labels Jun 18, 2020
@rarkins rarkins added the status:requirements Full requirements are not yet known, so implementation should not be started label Jan 12, 2021
@HonkingGoose
Copy link
Collaborator

@rarkins @viceice This issue should probably be reviewed, as there has been no real change to this issue since it was opened. We only moved some labels around... 😉

@viceice viceice added help wanted Help is needed or welcomed on this issue priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Mar 8, 2021
@viceice
Copy link
Member

viceice commented Mar 8, 2021

I think this is ready to be implemented but would need a community contribution 🙃

@viceice
Copy link
Member

viceice commented Mar 8, 2021

I think the gradle-wrapper manager can be used as base for this

@rarkins
Copy link
Collaborator

rarkins commented Mar 8, 2021

First step is probably to add a maven-version datasource modeled after lib/datasource/gradle-version

@breun
Copy link

breun commented Mar 1, 2022

Maven Wrapper has migrated from Takari to an official Maven project: https://maven.apache.org/wrapper/

@benkelaar
Copy link
Contributor

As mentioned in this discussion @trystian1 and I are working on this feature.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 34.111.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Help is needed or welcomed on this issue new package manager New package manager support priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@BigMichi1 @breun @viceice @benkelaar @rarkins @HonkingGoose @renovate-release and others