feat(maven-wrapper): Add manager to update maven wrapper version #15660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkelaar
changed the title
benkelaar
changed the title
rarkins
requested changes
May 28, 2022
Co-authored-by: Rhys Arkins <rhys@arkins.net>
viceice
requested changes
Jun 9, 2022
lib/modules/manager/maven-wrapper/__fixtures__/only-maven/maven-wrapper.properties
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
|
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
@benkelaar and me created this demo repo, which demonstrates updating maven wrapper and maven. This was run locally with Any other scenario's you want us to map out? |
|
The example repo looks good to me |
rarkins
previously approved these changes
Dec 15, 2022
viceice
reviewed
Dec 15, 2022
|
I'm still really hoping to see this merged 🤞 Thank you all for this great work and your continued efforts! |
|
some small issues need to be fixed before merge |
viceice
reviewed
Jan 19, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
approved these changes
Jan 23, 2023
viceice
changed the title
|
🎉 This PR is included in version 34.111.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge request for Issue #3566 , we still need to add some unit tests to get 100% coverage and look at whether the documentation needs to be updated, but we would like some first feedback on whether we've taken the right approach.
Changes
Add custom manager to do maven wrapper version upgrades of both maven version and maven wrapper version.
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: