Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add centralized secret sanitation #4444

Closed
rarkins opened this issue Sep 7, 2019 · 1 comment · Fixed by #4446
Closed

Add centralized secret sanitation #4444

rarkins opened this issue Sep 7, 2019 · 1 comment · Fixed by #4446
Labels
priority-2-high Bugs impacting wide number of users or very important features type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Sep 7, 2019

I'm thinking about adding a 'sanitize' function that uses the data in hostRules to (a) find every secret (e.g. token and password), and then (b) replace all occurrences in any string with **redacted**. Ideally we could pass every log message in raw format through it instead of having to decide fields in advance, and we should also pass issue, PR and comment bodies through it to be safe.

@rarkins rarkins added type:feature Feature (new functionality) ready priority-2-high Bugs impacting wide number of users or very important features labels Sep 7, 2019
rarkins added a commit that referenced this issue Sep 7, 2019
Adds a sanitize function to host-rules that redacts tokens and passwords from issues and PRs.

Closes #4444
rarkins added a commit that referenced this issue Sep 7, 2019
Adds a sanitize function to host-rules that redacts tokens and passwords from issues and PRs.

Closes #4444
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 19.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-2-high Bugs impacting wide number of users or very important features type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants