feat: centralized sanitation #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 19.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viceice
reviewed
Sep 7, 2019
| try { | ||
| const comments = await getComments(issueNo); | ||
| let body: string; | ||
| let commentId: number | null = null; | ||
| let commentNeedsUpdating = false; | ||
| if (topic) { | ||
| logger.debug(`Ensuring comment "${topic}" in #${issueNo}`); | ||
| body = `### ${topic}\n\n${content}`; | ||
| body = hostRules.sanitize(`### ${topic}\n\n${content}`); |
| logger.debug(`updatePr(${prNo}, ${title}, body)`); | ||
| const body = rawBody ? hostRules.sanitize(rawBody) : null; |
There was a problem hiding this comment.
hostRules.sanitize already checks for null
There was a problem hiding this comment.
body string should be removed from log.
do we need to rename params? Can we simply move the sanitize to the if below?
| secrets.push(secret); | ||
| }); | ||
| if (params.username && params.password) { | ||
| const secret = Buffer.from( |
There was a problem hiding this comment.
We should move this to a util function, because i've seen this on some more places.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sanitize function to host-rules that redacts tokens and passwords from issues and PRs.
Closes #4444