Crash on Azure when branch policy "Limit merge types" option is unchecked

[elwynelwyn]

This is a:

• Bug report (non-security related)
• Feature request
• I'm not sure which of those it is

I'm using:

• The Renovate GitHub App
• Self-hosted GitHub
• Self-hosted GitLab
• Self-hosted Azure DevOps
  via this VSTS task:
  https://marketplace.visualstudio.com/items?itemName=jyc.vsts-extensions-renovate-me

Please describe the issue:

When the repository has a branch policy on master but does NOT check the "Limit merge types" option, RenovateBot crashes with an unhandled null.
Enabling the option (but leaving all options selected - so effectively the same thing) fixes the crash.

e.g. checked like this screenshot is fine, but if I uncheck this, it crashes out.

The exception is thrown from node_modules\renovate\dist\platform\azure\azure-helper.js line 212 when it tries to do Object.keys(policyConfigurations) and policyConfigurations is null.

From the log:

ERROR: Repository has unknown error (repository=MyOrg/MyRepo)
"err": {
    "message": "Cannot convert undefined or null to object",
    "stack": "TypeError: Cannot convert undefined or null to object\n    at Function.keys (<anonymous>)\n    at Object.getMergeMethod (/home/vsts/.config/yarn/global/node_modules/renovate/dist/platform/azure/azure-helper.js:212:20)\n    at process._tickCallback (internal/process/next_tick.js:68:7)"
}

[JamieMagee]

@elwynelwyn Thanks for reporting this. I'll investigate further.

[renovate-release]

🎉 This issue has been resolved in version 19.66.16 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀